netdev - Re: [net-next 1/5] net: mdio: fwnode: add fwnode_mdiobus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 28 Mar 2022 15:03:16 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Clément Léger <clement.leger@...tlin.com>
Cc:     Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Horatiu Vultur <horatiu.vultur@...rochip.com>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Allan Nielsen <allan.nielsen@...rochip.com>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [net-next 1/5] net: mdio: fwnode: add fwnode_mdiobus_register()

On Mon, Mar 28, 2022 at 08:26:42AM +0200, Clément Léger wrote:
> Le Fri, 25 Mar 2022 19:38:24 +0100,
> Andrew Lunn <andrew@...n.ch> a écrit :
> 
> > On Fri, Mar 25, 2022 at 06:22:30PM +0100, Clément Léger wrote:
> > > In order to support software node description transparently, add fwnode
> > > support with fwnode_mdiobus_register(). This function behaves exactly
> > > like of_mdiobus_register() function but using the fwnode node agnostic
> > > API. This support might also be used to merge ACPI mdiobus support
> > > which is quite similar to the fwnode one.
> > > 
> > > Some part such as the whitelist matching are kept exclusively for OF
> > > nodes since it uses an of_device_id struct and seems tightly coupled
> > > with OF. Other parts are generic and will allow to move the existing
> > > OF support on top of this fwnode version.  
> > 
> > Does fwnode have any documentation? How does a developer know what
> > properties can be passed? Should you be adding a
> > 
> > Documentation/fwnode/bindings/net/mdio.yaml ?
> > 
> > 	Andrew
> 
> Hi Andrew,
> 
> Actually, fwnode is an abstraction for various firmware nodes such as
> ACPI, device-tree and software nodes. It allows to access properties,
> child and other attributes transparently from these various nodes but
> does not actually defines how they should describe the hardware. If
> there is specific hanling to be done, node type can be checked using
> is_acpi_node(), is_of_node() and so on.
> 
> I think it is still needed to document the bindings for each node type.

But you seem to be implementing a subset of what each node type
supports. So maybe it would be good to document which parts of the OF
binding can be used, which parts of the ACPI binding can be used, etc.

	Andrew