netdev - 答复: [PATCH] net: dsa: felix: fix possible NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <42986bf785de4d1aac454a9463f46915@huawei.com>
Date:   Tue, 29 Mar 2022 09:12:10 +0000
From:   zhengyongjun <zhengyongjun3@...wei.com>
To:     Paolo Abeni <pabeni@...hat.com>, "andrew@...n.ch" <andrew@...n.ch>,
        "vivien.didelot@...il.com" <vivien.didelot@...il.com>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "vladimir.oltean@....com" <vladimir.oltean@....com>,
        "claudiu.manoil@....com" <claudiu.manoil@....com>,
        "alexandre.belloni@...tlin.com" <alexandre.belloni@...tlin.com>,
        "UNGLinuxDriver@...rochip.com" <UNGLinuxDriver@...rochip.com>
Subject: 答复: [PATCH] net: dsa: felix: fix possible NULL pointer dereference

Thanks for point out my mistake :)
-----邮件原件-----
发件人: Paolo Abeni [mailto:pabeni@...hat.com] 
发送时间: 2022年3月29日 17:00
收件人: zhengyongjun <zhengyongjun3@...wei.com>; andrew@...n.ch; vivien.didelot@...il.com; f.fainelli@...il.com; davem@...emloft.net; kuba@...nel.org; netdev@...r.kernel.org; linux-kernel@...r.kernel.org
抄送: vladimir.oltean@....com; claudiu.manoil@....com; alexandre.belloni@...tlin.com; UNGLinuxDriver@...rochip.com
主题: Re: [PATCH] net: dsa: felix: fix possible NULL pointer dereference

Hello,

On Tue, 2022-03-29 at 08:12 +0000, Zheng Yongjun wrote:
> As the possible failure of the allocation, kzalloc() may return NULL 
> pointer.
> Therefore, it should be better to check the 'sgi' in order to prevent 
> the dereference of NULL pointer.
> 
> Fixes: 23ae3a7877718 ("net: dsa: felix: add stream gate settings for psfpq").

It looks like the fixes tag has been corrupted (trailing 'q'). Would you mind posting a v2 with that fixed ?

Thanks,

Paolo