netdev - Re: [PATCH 09/22] gpio-winbond: Use C99 initializers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 29 Mar 2022 14:30:40 +0200
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Benjamin Stürz <benni@...erz.xyz>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
        Gregory Clement <gregory.clement@...tlin.com>,
        Russell King <linux@...linux.org.uk>, linux@...tec.co.uk,
        Krzysztof Kozlowski <krzk@...nel.org>, alim.akhtar@...sung.com,
        Thomas Gleixner <tglx@...utronix.de>, mingo@...hat.com,
        Borislav Petkov <bp@...en8.de>, dave.hansen@...ux.intel.com,
        hpa@...or.com, robert.moore@...el.com,
        "Rafael J . Wysocki" <rafael.j.wysocki@...el.com>, lenb@...nel.org,
        3chas3@...il.com, laforge@...monks.org,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Tony Luck <tony.luck@...el.com>,
        James Morse <james.morse@....com>,
        Robert Richter <rric@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        mike.marciniszyn@...nelisnetworks.com,
        dennis.dalessandro@...nelisnetworks.com, jgg@...pe.ca,
        pali@...nel.org, Dmitry Torokhov <dmitry.torokhov@...il.com>,
        isdn@...ux-pingi.de,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        fbarrat@...ux.ibm.com, ajd@...ux.ibm.com,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, nico@...xnic.net,
        loic.poulain@...aro.org, kvalo@...nel.org, pkshih@...ltek.com,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-samsung-soc@...r.kernel.org, linux-ia64@...r.kernel.org,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        devel@...ica.org, linux-atm-general@...ts.sourceforge.net,
        netdev <netdev@...r.kernel.org>, linux-edac@...r.kernel.org,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        linux-rdma@...r.kernel.org,
        Linux Input <linux-input@...r.kernel.org>,
        linuxppc-dev@...ts.ozlabs.org,
        Linux Media Mailing List <linux-media@...r.kernel.org>,
        wcn36xx@...ts.infradead.org, linux-wireless@...r.kernel.org,
        linux-pci@...r.kernel.org
Subject: Re: [PATCH 09/22] gpio-winbond: Use C99 initializers

On Sat, Mar 26, 2022 at 6:00 PM Benjamin Stürz <benni@...erz.xyz> wrote:
>
> This replaces comments with C99's designated
> initializers because the kernel supports them now.
>
> Signed-off-by: Benjamin Stürz <benni@...erz.xyz>
> ---
>  drivers/gpio/gpio-winbond.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpio/gpio-winbond.c b/drivers/gpio/gpio-winbond.c
> index 7f8f5b02e31d..0b637fdb407c 100644
> --- a/drivers/gpio/gpio-winbond.c
> +++ b/drivers/gpio/gpio-winbond.c
> @@ -249,7 +249,7 @@ struct winbond_gpio_info {
>  };
>
>  static const struct winbond_gpio_info winbond_gpio_infos[6] = {
> -       { /* 0 */
> +       [0] = {
>                 .dev = WB_SIO_DEV_GPIO12,
>                 .enablereg = WB_SIO_GPIO12_REG_ENABLE,
>                 .enablebit = WB_SIO_GPIO12_ENABLE_1,
> @@ -266,7 +266,7 @@ static const struct winbond_gpio_info winbond_gpio_infos[6] = {
>                         .warnonly = true
>                 }
>         },
> -       { /* 1 */
> +       [1] = {
>                 .dev = WB_SIO_DEV_GPIO12,
>                 .enablereg = WB_SIO_GPIO12_REG_ENABLE,
>                 .enablebit = WB_SIO_GPIO12_ENABLE_2,
> @@ -277,7 +277,7 @@ static const struct winbond_gpio_info winbond_gpio_infos[6] = {
>                 .datareg = WB_SIO_GPIO12_REG_DATA2
>                 /* special conflict handling so doesn't use conflict data */
>         },
> -       { /* 2 */
> +       [2] = {
>                 .dev = WB_SIO_DEV_GPIO34,
>                 .enablereg = WB_SIO_GPIO34_REG_ENABLE,
>                 .enablebit = WB_SIO_GPIO34_ENABLE_3,
> @@ -294,7 +294,7 @@ static const struct winbond_gpio_info winbond_gpio_infos[6] = {
>                         .warnonly = true
>                 }
>         },
> -       { /* 3 */
> +       [3] = {
>                 .dev = WB_SIO_DEV_GPIO34,
>                 .enablereg = WB_SIO_GPIO34_REG_ENABLE,
>                 .enablebit = WB_SIO_GPIO34_ENABLE_4,
> @@ -311,7 +311,7 @@ static const struct winbond_gpio_info winbond_gpio_infos[6] = {
>                         .warnonly = true
>                 }
>         },
> -       { /* 4 */
> +       [4] = {
>                 .dev = WB_SIO_DEV_WDGPIO56,
>                 .enablereg = WB_SIO_WDGPIO56_REG_ENABLE,
>                 .enablebit = WB_SIO_WDGPIO56_ENABLE_5,
> @@ -328,7 +328,7 @@ static const struct winbond_gpio_info winbond_gpio_infos[6] = {
>                         .warnonly = true
>                 }
>         },
> -       { /* 5 */
> +       [5] = {
>                 .dev = WB_SIO_DEV_WDGPIO56,
>                 .enablereg = WB_SIO_WDGPIO56_REG_ENABLE,
>                 .enablebit = WB_SIO_WDGPIO56_ENABLE_6,
> --
> 2.35.1
>

Acked-by: Bartosz Golaszewski <brgl@...ev.pl>