netdev - Re: [PATCH net] sctp: count singleton chunks in assoc user stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220329130050.vwo5zcbgr7z2qpg5@t14s.localdomain>
Date:   Tue, 29 Mar 2022 10:00:50 -0300
From:   Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
To:     Jamie Bainbridge <jamie.bainbridge@...il.com>
Cc:     Vlad Yasevich <vyasevich@...il.com>,
        Neil Horman <nhorman@...driver.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, linux-sctp@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] sctp: count singleton chunks in assoc user stats

On Tue, Mar 29, 2022 at 01:13:36PM +1000, Jamie Bainbridge wrote:
> singleton chunks (INIT, and less importantly SHUTDOWN and SHUTDOWN-
> COMPLETE) are not counted in SCTP_GET_ASOC_STATS "sas_octrlchunks"
> counter available to the assoc owner.
> 
> INIT (and the SHUTDOWN chunks) are control chunks so they should be
> counted as such.
> 
> Add counting of singleton chunks so they are properly accounted for.
> 
> Signed-off-by: Jamie Bainbridge <jamie.bainbridge@...il.com>
> ---
>  net/sctp/outqueue.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/net/sctp/outqueue.c b/net/sctp/outqueue.c
> index a18609f608fb786b2532a4febbd72a9737ab906c..e2d7c955f07c80da17c7525159aaf8a053432ae3 100644
> --- a/net/sctp/outqueue.c
> +++ b/net/sctp/outqueue.c
> @@ -914,6 +914,7 @@ static void sctp_outq_flush_ctrl(struct sctp_flush_ctx *ctx)
>  				ctx->asoc->base.sk->sk_err = -error;
>  				return;
>  			}
> +			ctx->asoc->stats.octrlchunks++;
>  			break;
>  
>  		case SCTP_CID_ABORT:

Please also fix it for pmtu probes a bit below. They are heartbeats
being handled specially as singletons as well.

  Marcelo