lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 29 Mar 2022 09:28:14 -0600 From: Shuah Khan <skhan@...uxfoundation.org> To: davidcomponentone@...il.com, keescook@...omium.org Cc: luto@...capital.net, wad@...omium.org, shuah@...nel.org, ast@...nel.org, daniel@...earbox.net, andrii@...nel.org, kafai@...com, songliubraving@...com, yhs@...com, john.fastabend@...il.com, kpsingh@...nel.org, linux-kselftest@...r.kernel.org, netdev@...r.kernel.org, bpf@...r.kernel.org, linux-kernel@...r.kernel.org, Yang Guang <yang.guang5@....com.cn>, Shuah Khan <skhan@...uxfoundation.org> Subject: Re: [PATCH] selftests/seccomp: Add SKIP for failed unshare() On 3/29/22 12:03 AM, davidcomponentone@...il.com wrote: > From: Yang Guang <yang.guang5@....com.cn> > > Running the seccomp tests under the kernel with "defconfig" > shouldn't fail. Because the CONFIG_USER_NS is not support Nit - supported > in "defconfig". So skip this test case is better. Nit: "skipping this case instead if failing it." > > Signed-off-by: Yang Guang <yang.guang5@....com.cn> > Signed-off-by: David Yang <davidcomponentone@...il.com> > --- > tools/testing/selftests/seccomp/seccomp_bpf.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/seccomp/seccomp_bpf.c b/tools/testing/selftests/seccomp/seccomp_bpf.c > index 313bb0cbfb1e..e9a61cb2eb88 100644 > --- a/tools/testing/selftests/seccomp/seccomp_bpf.c > +++ b/tools/testing/selftests/seccomp/seccomp_bpf.c > @@ -3742,7 +3742,10 @@ TEST(user_notification_fault_recv) > struct seccomp_notif req = {}; > struct seccomp_notif_resp resp = {}; > > - ASSERT_EQ(unshare(CLONE_NEWUSER), 0); > + ASSERT_EQ(unshare(CLONE_NEWUSER), 0) { > + if (errno == EINVAL) > + SKIP(return, "kernel missing CLONE_NEWUSER support");> + } > > listener = user_notif_syscall(__NR_getppid, > SECCOMP_FILTER_FLAG_NEW_LISTENER); > Looks good to me. Looks like this patch is for Linux 5.18 repo. With the requested changes to commit log Reviewed-by: Shuah Khan <skhan@...uxfoundation.org> thanks, -- Shuah
Powered by blists - more mailing lists