lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 30 Mar 2022 14:18:35 +0200 From: Alexander Lobakin <alexandr.lobakin@...el.com> To: "David S. Miller" <davem@...emloft.net>, "Jakub Kicinski" <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com> Cc: Alexander Lobakin <alexandr.lobakin@...el.com>, Jacob Keller <jacob.e.keller@...el.com>, ivecera <ivecera@...hat.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, poros <poros@...hat.com>, mschmidt <mschmidt@...hat.com>, Jesse Brandeburg <jesse.brandeburg@...el.com>, Tony Nguyen <anthony.l.nguyen@...el.com>, "moderated list:INTEL ETHERNET DRIVERS" <intel-wired-lan@...ts.osuosl.org>, open list <linux-kernel@...r.kernel.org> Subject: Re: [PATCH net v2] ice: Fix MAC address setting From: Jacob Keller <jacob.e.keller@...el.com> Date: Mon, 28 Mar 2022 17:53:19 +0000 Hey netdev maintainers, > > -----Original Message----- > > From: Ivan Vecera <ivecera@...hat.com> > > Sent: Friday, March 25, 2022 6:25 AM > > To: netdev@...r.kernel.org > > Cc: poros <poros@...hat.com>; mschmidt <mschmidt@...hat.com>; > > Brandeburg, Jesse <jesse.brandeburg@...el.com>; Nguyen, Anthony L > > <anthony.l.nguyen@...el.com>; David S. Miller <davem@...emloft.net>; Jakub > > Kicinski <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>; moderated > > list:INTEL ETHERNET DRIVERS <intel-wired-lan@...ts.osuosl.org>; open list <linux- > > kernel@...r.kernel.org> > > Subject: [PATCH net v2] ice: Fix MAC address setting > > > > Commit 2ccc1c1ccc671b ("ice: Remove excess error variables") merged > > the usage of 'status' and 'err' variables into single one in > > function ice_set_mac_address(). Unfortunately this causes > > a regression when call of ice_fltr_add_mac() returns -EEXIST because > > this return value does not indicate an error in this case but > > value of 'err' remains to be -EEXIST till the end of the function > > and is returned to caller. > > > > Prior mentioned commit this does not happen because return value of > > ice_fltr_add_mac() was stored to 'status' variable first and > > if it was -EEXIST then 'err' remains to be zero. > > > > Fix the problem by reset 'err' to zero when ice_fltr_add_mac() > > returns -EEXIST. > > > > Fixes: 2ccc1c1ccc671b ("ice: Remove excess error variables") > > Signed-off-by: Ivan Vecera <ivecera@...hat.com> > > --- > > Thanks for the v2. This looks great. Good analysis of how this happened in the commit message, I appreciate that. > > Reviewed-by: Jacob Keller <jacob.e.keller@...el.com> This is an urgent fix, so we would like it to go through -net, not IWL. It has this Reviewed-by, and also Acked-by: Alexander Lobakin <alexandr.lobakin@...el.com> > > > drivers/net/ethernet/intel/ice/ice_main.c | 7 +++++-- > > 1 file changed, 5 insertions(+), 2 deletions(-) > > --- 8< --- > > -- > > 2.34.1 Thanks, Al
Powered by blists - more mailing lists