netdev - Re: [PATCH net] ice: Fix logic of getting XSK pool associated with Tx queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220330170046.3604787-1-alexandr.lobakin@intel.com>
Date:   Wed, 30 Mar 2022 19:00:46 +0200
From:   Alexander Lobakin <alexandr.lobakin@...el.com>
To:     Alice Michael <alice.michael@...el.com>
Cc:     Alexander Lobakin <alexandr.lobakin@...el.com>,
        Ivan Vecera <ivecera@...hat.com>,
        Maciej Fijalkowski <maciej.fijalkowski@...el.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        poros <poros@...hat.com>, mschmidt <mschmidt@...hat.com>,
        Jesse Brandeburg <jesse.brandeburg@...el.com>,
        Tony Nguyen <anthony.l.nguyen@...el.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        John Fastabend <john.fastabend@...il.com>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        KP Singh <kpsingh@...nel.org>,
        "moderated list:INTEL ETHERNET DRIVERS" 
        <intel-wired-lan@...ts.osuosl.org>,
        open list <linux-kernel@...r.kernel.org>,
        "open list:XDP (eXpress Data Path)" <bpf@...r.kernel.org>
Subject: Re: [PATCH net] ice: Fix logic of getting XSK pool associated with Tx queue

From: Alice Michael <alice.michael@...el.com>
Date: Wed, 30 Mar 2022 16:47:18 +0000

> > -----Original Message-----
> > From: Ivan Vecera <ivecera@...hat.com>
> > Sent: Tuesday, March 29, 2022 10:55 AM
> > To: Fijalkowski, Maciej <maciej.fijalkowski@...el.com>
> > Cc: netdev@...r.kernel.org; poros <poros@...hat.com>; mschmidt
> > <mschmidt@...hat.com>; Brandeburg, Jesse
> > <jesse.brandeburg@...el.com>; Nguyen, Anthony L
> > <anthony.l.nguyen@...el.com>; David S. Miller <davem@...emloft.net>;
> > Jakub Kicinski <kuba@...nel.org>; Paolo Abeni <pabeni@...hat.com>;
> > Alexei Starovoitov <ast@...nel.org>; Daniel Borkmann
> > <daniel@...earbox.net>; Jesper Dangaard Brouer <hawk@...nel.org>; John
> > Fastabend <john.fastabend@...il.com>; Andrii Nakryiko
> > <andrii@...nel.org>; Martin KaFai Lau <kafai@...com>; Song Liu
> > <songliubraving@...com>; Yonghong Song <yhs@...com>; KP Singh
> > <kpsingh@...nel.org>; Jeff Kirsher <jeffrey.t.kirsher@...el.com>; Krzysztof
> > Kazimierczak <krzysztof.kazimierczak@...el.com>; Lobakin, Alexandr
> > <alexandr.lobakin@...el.com>; moderated list:INTEL ETHERNET DRIVERS
> > <intel-wired-lan@...ts.osuosl.org>; open list <linux-kernel@...r.kernel.org>;
> > open list:XDP (eXpress Data Path) <bpf@...r.kernel.org>
> > Subject: Re: [PATCH net] ice: Fix logic of getting XSK pool associated with Tx
> > queue
> > 
> > On Tue, 29 Mar 2022 14:00:01 +0200
> > Maciej Fijalkowski <maciej.fijalkowski@...el.com> wrote:
> > 
> > > Thanks for this fix! I did exactly the same patch yesterday and it's
> > > already applied to bpf tree:
> > >
> > > https://lore.kernel.org/bpf/20220328142123.170157-5-maciej.fijalkowski
> > > @intel.com/T/#u
> > >
> > > Maciej
> > 
> > Thanks for info... Nice human race condition ;-)
> > 
> > I.
> 
> I'm covering for Tony this week maintaining this tree.  He let me know there were a few patches you had to send Ivan and I was waiting on this one.  If I'm following correctly, this one will be dropped and the other ones are ready to be sent now to net then?

Yes, this one is beaten and the net tree already contains it[0].
There are still 3 Ivan's fixes not applied yet:
 * [1]
 * [2]
 * [3]

I'm wondering if it's worth to pass them through dev-queue since
they're urgent and have been tested already in 2 companies? They
could go directly to -net and make it into RC1.

> 
> Alice.

[0] https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git/commit/?id=1ac2524de7b366633fc336db6c94062768d0ab03
[1] https://lore.kernel.org/netdev/20220322142554.3253428-1-ivecera@redhat.com
[2] https://lore.kernel.org/netdev/20220325132524.1765342-1-ivecera@redhat.com
[3] https://lore.kernel.org/netdev/20220325132819.1767050-1-ivecera@redhat.com

Thanks,
Al