netdev - Re: [PATCH v7 net 4/4] net: axiemac: use a phandle to reference pcs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YkOxexKUQqmFVe9l@lunn.ch>
Date:   Wed, 30 Mar 2022 03:25:15 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Andy Chiu <andy.chiu@...ive.com>, radhey.shyam.pandey@...inx.com,
        robert.hancock@...ian.com, michal.simek@...inx.com,
        davem@...emloft.net, pabeni@...hat.com, robh+dt@...nel.org,
        linux@...linux.org.uk, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, robh@...nel.org,
        Greentime Hu <greentime.hu@...ive.com>
Subject: Re: [PATCH v7 net 4/4] net: axiemac: use a phandle to reference
 pcs_phy

On Tue, Mar 29, 2022 at 03:56:09PM -0700, Jakub Kicinski wrote:
> On Tue, 29 Mar 2022 10:49:21 +0800 Andy Chiu wrote:
> > In some SGMII use cases where both a fixed link external PHY and the
> > internal PCS/PMA PHY need to be configured, we should explicitly use a
> > phandle "pcs-phy" to get the reference to the PCS/PMA PHY. Otherwise, the
> > driver would use "phy-handle" in the DT as the reference to both the
> > external and the internal PCS/PMA PHY.
> > 
> > In other cases where the core is connected to a SFP cage, we could still
> > point phy-handle to the intenal PCS/PMA PHY, and let the driver connect
> > to the SFP module, if exist, via phylink.
> > 
> > Fixes: 1a02556086fc (net: axienet: Properly handle PCS/PMA PHY for 1000BaseX mode)
> > Signed-off-by: Andy Chiu <andy.chiu@...ive.com>
> > Reviewed-by: Greentime Hu <greentime.hu@...ive.com>
> > Reviewed-by: Robert Hancock <robert.hancock@...ian.com>
> 
> I'm not sure if this is a fix or adding support for a new configuration.
> Andrew, WDYT?

I guess it fails this stable rule:

It must fix a problem that causes a build error (but not for things
marked CONFIG_BROKEN), an oops, a hang, data corruption, a real
security issue, or some “oh, that’s not good” issue. In short,
something critical.

So this probably should be for net-next.

   Andrew