netdev - Re: [syzbot] memory leak in gs_usb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220330073735.tqfmyfgzyfbqmkpn@pengutronix.de>
Date:   Wed, 30 Mar 2022 09:37:35 +0200
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     "Zhang, Qiang1" <qiang1.zhang@...el.com>
Cc:     syzbot <syzbot+4d0ae90a195b269f102d@...kaller.appspotmail.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "linux-can@...r.kernel.org" <linux-can@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "pfink@...ist-es.de" <pfink@...ist-es.de>,
        "syzkaller-bugs@...glegroups.com" <syzkaller-bugs@...glegroups.com>,
        "wg@...ndegger.com" <wg@...ndegger.com>
Subject: Re: [syzbot] memory leak in gs_usb_probe

On 30.03.2022 01:57:08, Zhang, Qiang1 wrote:
> Hello,
> 
> syzbot found the following issue on:
> 
> HEAD commit:    52deda9551a0 Merge branch 'akpm' (patches from Andrew)
> git tree:       upstream
> console output: https://syzkaller.appspot.com/x/log.txt?x=12b472dd700000
> kernel config:  https://syzkaller.appspot.com/x/.config?x=9ca2a67ddb20027f
> dashboard link: https://syzkaller.appspot.com/bug?extid=4d0ae90a195b269f102d
> compiler:       gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2
> syz repro:      https://syzkaller.appspot.com/x/repro.syz?x=12e96e1d700000
> C reproducer:   https://syzkaller.appspot.com/x/repro.c?x=12f8b513700000
> 
> IMPORTANT: if you fix the issue, please add the following tag to the commit:
> Reported-by: syzbot+4d0ae90a195b269f102d@...kaller.appspotmail.com

[...]

> diff --git a/drivers/net/can/usb/gs_usb.c b/drivers/net/can/usb/gs_usb.c
> index 67408e316062..5234cfff84b8 100644
> --- a/drivers/net/can/usb/gs_usb.c
> +++ b/drivers/net/can/usb/gs_usb.c
> @@ -1092,6 +1092,7 @@ static struct gs_can *gs_make_candev(unsigned int channel,
>                 dev->data_bt_const.brp_inc = le32_to_cpu(bt_const_extended->dbrp_inc);
> 
>                 dev->can.data_bittiming_const = &dev->data_bt_const;
> +               kfree(bt_const_extended);
>         }
> 
>         SET_NETDEV_DEV(netdev, &intf->dev);

I have already send a similar fix:

| https://lore.kernel.org/all/20220329193450.659726-1-mkl@pengutronix.de

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)