netdev - Re: [PATCH v8 0/7] CTU CAN FD open-source IP core SocketCAN driver, PCI, platform integration and documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20220330075422.4kxnayrdcxz7o5lo@pengutronix.de>
Date:   Wed, 30 Mar 2022 09:54:22 +0200
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Ondrej Ille <ondrej.ille@...il.com>
Cc:     Pavel Pisa <pisa@....felk.cvut.cz>, linux-can@...r.kernel.org,
        devicetree@...r.kernel.org,
        Oliver Hartkopp <socketcan@...tkopp.net>,
        Wolfgang Grandegger <wg@...ndegger.com>,
        David Miller <davem@...emloft.net>,
        Rob Herring <robh+dt@...nel.org>, mark.rutland@....com,
        Carsten Emde <c.emde@...dl.org>, armbru@...hat.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Marin Jerabek <martin.jerabek01@...il.com>,
        Jiri Novak <jnovak@....cvut.cz>,
        Jaroslav Beran <jara.beran@...il.com>,
        Petr Porazil <porazil@...ron.com>, Pavel Machek <pavel@....cz>,
        Drew Fustini <pdp7pdp7@...il.com>
Subject: Re: [PATCH v8 0/7] CTU CAN FD open-source IP core SocketCAN driver,
 PCI, platform integration and documentation

On 30.03.2022 09:46:08, Ondrej Ille wrote:
> sorry for the late reply, my work duties are keeping me very busy.

Known problem :)

> Let me just quickly comment on topics discussed in the emails above.
> 
> *1. Separation of PROP and TSEG1*
> 
> IMHO there is no real benefit. The reason why CTU CAN FD has this
> split is legacy. First implementation back in 2015 had this split
> since I wanted to follow the standard. In HW, the first thing done in
> bit timing logic (prescaler module), these two numbers are added, and
> all further resynchronization/hard-synchronization is done with TSEG1
> value...

Thanks for the insight. It's not easy to get in touch with the
developers of the proprietary IP cores :)

Never the less, there's another IP core which has different sizes for
the prop and tseg1 register. So an update of the bit timing constant
would help both.

> *2. Number of TXT Buffers and RX Buffer size:*
> 
> Pavel already replied with TXTB_INFO. The same role has the RX_MEM_INFO
> register, when it comes to RX side.

Thanks for the clarification.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)