netdev - Re: [PATCH net] rxrpc: fix some null-ptr-deref bugs in server

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3114597.1648729013@warthog.procyon.org.uk>
Date:   Thu, 31 Mar 2022 13:16:53 +0100
From:   David Howells <dhowells@...hat.com>
To:     Paolo Abeni <pabeni@...hat.com>
Cc:     dhowells@...hat.com, netdev@...r.kernel.org,
        Xiaolong Huang <butterflyhuangxx@...il.com>,
        Marc Dionne <marc.dionne@...istor.com>,
        linux-afs@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] rxrpc: fix some null-ptr-deref bugs in server_key.c

Paolo Abeni <pabeni@...hat.com> wrote:

> It looks like we can add a couple of fixes tag to help stable teams:
> 
> Fixes: d5953f6543b5 ("rxrpc: Allow security classes to give more info on server keys")

Not this one.  This includes a check for the one op it adds:

	+       if (sec && sec->describe_server_key)
	+               sec->describe_server_key(key, m);


> Fixes: 12da59fcab5a ("xrpc: Hand server key parsing off to the security class")

There's a missing 'r' in "rxrpc:" in the patch subject, but otherwise this one
looks like the right one.

Thanks,
David