lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 31 Mar 2022 14:35:02 +0200
From:   Florent Fourcot <>
Cc:     Florent Fourcot <>,
        Brian Baboch <>
Subject: [PATCH net-next] rtnetlink: return ENODEV when ifname does not exist and group is given

When the interface does not exist, and a group is given, the given
parameters are being set to all interfaces of the given group. The given
IFNAME/ALT_IF_NAME are being ignored in that case.

That can be dangerous since a typo (or a deleted interface) can produce
weird side effects for caller:

Case 1:


Case 1 will update MTU and group of the given interface "valid_interface".

Case 2:


Case 2 will update MTU of all interfaces in group 1. IFLA_IFNAME is
ignored in this case

This behaviour is not consistent and dangerous. In order to fix this issue,
we now return ENODEV when the given IFNAME does not exist.

Signed-off-by: Florent Fourcot <>
Signed-off-by: Brian Baboch <>
 net/core/rtnetlink.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index 159c9c61e6af..3313419bbcba 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -3417,10 +3417,15 @@ static int __rtnl_newlink(struct sk_buff *skb, struct nlmsghdr *nlh,
 	if (!(nlh->nlmsg_flags & NLM_F_CREATE)) {
-		if (ifm->ifi_index == 0 && tb[IFLA_GROUP])
+		if (ifm->ifi_index == 0 && tb[IFLA_GROUP]) {
+			if (tb[IFLA_IFNAME] || tb[IFLA_ALT_IFNAME]) {
+				NL_SET_ERR_MSG(extack, "Cannot find interface with given name");
+				return -ENODEV;
+			}
 			return rtnl_group_changelink(skb, net,
 						ifm, extack, tb);
+		}
 		return -ENODEV;

Powered by blists - more mailing lists