lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 31 Mar 2022 13:01:49 +0000 From: "Nagaraju, Shwetha" <shwetha.nagaraju@...el.com> To: "Fijalkowski, Maciej" <maciej.fijalkowski@...el.com>, "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org> CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "kuba@...nel.org" <kuba@...nel.org>, "bpf@...r.kernel.org" <bpf@...r.kernel.org>, "davem@...emloft.net" <davem@...emloft.net>, "Karlsson, Magnus" <magnus.karlsson@...el.com> Subject: RE: [Intel-wired-lan] [PATCH intel-net 1/3] ice: synchronize_rcu() when terminating rings > -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of > Maciej Fijalkowski > Sent: Friday, March 18, 2022 12:06 AM > To: intel-wired-lan@...ts.osuosl.org > Cc: netdev@...r.kernel.org; kuba@...nel.org; bpf@...r.kernel.org; > davem@...emloft.net; Karlsson, Magnus <magnus.karlsson@...el.com> > Subject: [Intel-wired-lan] [PATCH intel-net 1/3] ice: synchronize_rcu() when > terminating rings > > Unfortunately, the ice driver doesn't respect the RCU critical section that XSK > wakeup is surrounded with. To fix this, add synchronize_rcu() calls to paths > that destroy resources that might be in use. > > This was addressed in other AF_XDP ZC enabled drivers, for reference see > for example commit b3873a5be757 ("net/i40e: Fix concurrency issues > between config flow and XSK") > > Fixes: efc2214b6047 ("ice: Add support for XDP") > Fixes: 2d4238f55697 ("ice: Add support for AF_XDP") > Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com> > --- > drivers/net/ethernet/intel/ice/ice.h | 2 +- > drivers/net/ethernet/intel/ice/ice_main.c | 4 +++- > drivers/net/ethernet/intel/ice/ice_xsk.c | 4 +++- > 3 files changed, 7 insertions(+), 3 deletions(-) > Tested-by: Shwetha Nagaraju <Shwetha.nagaraju@...el.com>
Powered by blists - more mailing lists