lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 31 Mar 2022 09:14:47 -0700 From: Shannon Nelson <snelson@...sando.io> To: Leon Romanovsky <leon@...nel.org>, "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org> Cc: Leon Romanovsky <leonro@...dia.com>, intel-wired-lan@...ts.osuosl.org, Jeff Kirsher <jeffrey.t.kirsher@...el.com>, Jesse Brandeburg <jesse.brandeburg@...el.com>, linux-kernel@...r.kernel.org, netdev@...r.kernel.org, Paolo Abeni <pabeni@...hat.com>, Raed Salem <raeds@...dia.com>, Shannon Nelson <shannon.nelson@...cle.com>, Tony Nguyen <anthony.l.nguyen@...el.com>, Steffen Klassert <steffen.klassert@...unet.com> Subject: Re: [PATCH net v1] ixgbe: ensure IPsec VF<->PF compatibility On 3/31/22 1:20 AM, Leon Romanovsky wrote: > From: Leon Romanovsky <leonro@...dia.com> > > The VF driver can forward any IPsec flags and such makes the function > is not extendable and prone to backward/forward incompatibility. > > If new software runs on VF, it won't know that PF configured something > completely different as it "knows" only XFRM_OFFLOAD_INBOUND flag. > > Fixes: eda0333ac293 ("ixgbe: add VF IPsec management") > Reviewed-by: Raed Salem <raeds@...dia.com> > Signed-off-by: Leon Romanovsky <leonro@...dia.com>a Thanks! Reviewed-by: Shannon Nelson <snelson@...sando.io> > --- > Chaagelog: > v1: > * Replaced bits arithmetic with more simple expression > v0: https://lore.kernel.org/all/3702fad8a016170947da5f3c521a9251cf0f4a22.1648637865.git.leonro@nvidia.com > --- > drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c > index e596e1a9fc75..69d11ff7677d 100644 > --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c > +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c > @@ -903,7 +903,8 @@ int ixgbe_ipsec_vf_add_sa(struct ixgbe_adapter *adapter, u32 *msgbuf, u32 vf) > /* Tx IPsec offload doesn't seem to work on this > * device, so block these requests for now. > */ > - if (!(sam->flags & XFRM_OFFLOAD_INBOUND)) { > + sam->flags = sam->flags & ~XFRM_OFFLOAD_IPV6; > + if (sam->flags != XFRM_OFFLOAD_INBOUND) { > err = -EOPNOTSUPP; > goto err_out; > }
Powered by blists - more mailing lists