netdev - Re: [PATCH net] vxlan: do not feed vxlan_vnifilter_dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 30 Mar 2022 20:14:05 -0700
From:   Roopa Prabhu <roopa@...dia.com>
To:     Eric Dumazet <eric.dumazet@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Cc:     netdev <netdev@...r.kernel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        syzbot <syzkaller@...glegroups.com>
Subject: Re: [PATCH net] vxlan: do not feed vxlan_vnifilter_dump_dev with non
 vxlan devices


On 3/30/22 12:46, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@...gle.com>
>
> vxlan_vnifilter_dump_dev() assumes it is called only
> for vxlan devices. Make sure it is the case.
>
> BUG: KASAN: slab-out-of-bounds in vxlan_vnifilter_dump_dev+0x9a0/0xb40 drivers/net/vxlan/vxlan_vnifilter.c:349
> Read of size 4 at addr ffff888060d1ce70 by task syz-executor.3/17662
>
> CPU: 0 PID: 17662 Comm: syz-executor.3 Tainted: G        W         5.17.0-syzkaller-12888-g77c9387c0c5b #0
> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
> Call Trace:
>   <TASK>
>   __dump_stack lib/dump_stack.c:88 [inline]
>   dump_stack_lvl+0xcd/0x134 lib/dump_stack.c:106
>   print_address_description.constprop.0.cold+0xeb/0x495 mm/kasan/report.c:313
>   print_report mm/kasan/report.c:429 [inline]
>   kasan_report.cold+0xf4/0x1c6 mm/kasan/report.c:491
>   vxlan_vnifilter_dump_dev+0x9a0/0xb40 drivers/net/vxlan/vxlan_vnifilter.c:349
>   vxlan_vnifilter_dump+0x3ff/0x650 drivers/net/vxlan/vxlan_vnifilter.c:428
>   netlink_dump+0x4b5/0xb70 net/netlink/af_netlink.c:2270
>   __netlink_dump_start+0x647/0x900 net/netlink/af_netlink.c:2375
>   netlink_dump_start include/linux/netlink.h:245 [inline]
>   rtnetlink_rcv_msg+0x70c/0xb80 net/core/rtnetlink.c:5953
>   netlink_rcv_skb+0x153/0x420 net/netlink/af_netlink.c:2496
>   netlink_unicast_kernel net/netlink/af_netlink.c:1319 [inline]
>   netlink_unicast+0x543/0x7f0 net/netlink/af_netlink.c:1345
>   netlink_sendmsg+0x904/0xe00 net/netlink/af_netlink.c:1921
>   sock_sendmsg_nosec net/socket.c:705 [inline]
>   sock_sendmsg+0xcf/0x120 net/socket.c:725
>   ____sys_sendmsg+0x6e2/0x800 net/socket.c:2413
>   ___sys_sendmsg+0xf3/0x170 net/socket.c:2467
>   __sys_sendmsg+0xe5/0x1b0 net/socket.c:2496
>   do_syscall_x64 arch/x86/entry/common.c:50 [inline]
>   do_syscall_64+0x35/0x80 arch/x86/entry/common.c:80
>   entry_SYSCALL_64_after_hwframe+0x44/0xae
> RIP: 0033:0x7f87b8e89049
>
> Fixes: f9c4bb0b245c ("vxlan: vni filtering support on collect metadata device")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Roopa Prabhu <roopa@...dia.com>
> Reported-by: syzbot <syzkaller@...glegroups.com>

Acked-by: Roopa Prabhu <roopa@...dia.com>

I thought i had a check there. thanks for the patch eric!.