lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CO1PR11MB5089888D13802251F6830A8ED6E19@CO1PR11MB5089.namprd11.prod.outlook.com> Date: Thu, 31 Mar 2022 19:59:11 +0000 From: "Keller, Jacob E" <jacob.e.keller@...el.com> To: Brett Creeley <brett@...sando.io>, "Fijalkowski, Maciej" <maciej.fijalkowski@...el.com> CC: ivecera <ivecera@...hat.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "moderated list:INTEL ETHERNET DRIVERS" <intel-wired-lan@...ts.osuosl.org>, mschmidt <mschmidt@...hat.com>, open list <linux-kernel@...r.kernel.org>, poros <poros@...hat.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, "David S. Miller" <davem@...emloft.net> Subject: RE: [Intel-wired-lan] [PATCH net] ice: Fix incorrect locking in ice_vc_process_vf_msg() > -----Original Message----- > From: Brett Creeley <brett@...sando.io> > Sent: Thursday, March 31, 2022 9:33 AM > To: Fijalkowski, Maciej <maciej.fijalkowski@...el.com> > Cc: ivecera <ivecera@...hat.com>; netdev@...r.kernel.org; moderated > list:INTEL ETHERNET DRIVERS <intel-wired-lan@...ts.osuosl.org>; mschmidt > <mschmidt@...hat.com>; open list <linux-kernel@...r.kernel.org>; poros > <poros@...hat.com>; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni > <pabeni@...hat.com>; David S. Miller <davem@...emloft.net>; Keller, Jacob E > <jacob.e.keller@...el.com> > Subject: Re: [Intel-wired-lan] [PATCH net] ice: Fix incorrect locking in > ice_vc_process_vf_msg() > > On Thu, Mar 31, 2022 at 6:17 AM Maciej Fijalkowski > <maciej.fijalkowski@...el.com> wrote: > > > > On Thu, Mar 31, 2022 at 03:14:32PM +0200, Maciej Fijalkowski wrote: > > > On Thu, Mar 31, 2022 at 12:50:04PM +0200, Ivan Vecera wrote: > > > > Usage of mutex_trylock() in ice_vc_process_vf_msg() is incorrect > > > > because message sent from VF is ignored and never processed. > > > > > > > > Use mutex_lock() instead to fix the issue. It is safe because this > > > > > > We need to know what is *the* issue in the first place. > > > Could you please provide more context what is being fixed to the readers > > > that don't have an access to bugzilla? > > > > > > Specifically, what is the case that ignoring a particular message when > > > mutex is already held is a broken behavior? > > > > Uh oh, let's > > CC: Brett Creeley <brett@...sando.io> > Thanks for responding, Brett! :) > My concern here is that we don't want to handle messages > from the context of the "previous" VF configuration if that > makes sense. > Makes sense. Perhaps we need to do some sort of "clear the existing message queue" when we initiate a reset? > It might be best to grab the cfg_lock before doing any > message/VF validating in ice_vc_process_vf_msg() to > make sure all of the checks are done under the cfg_lock. > Yes that seems like it should be done. > CC'ing Jake so he can provide some input as > well. Thanks, Jake
Powered by blists - more mailing lists