netdev - Re: [PATCH net-next] dt-bindings: net: convert sff,sfp to dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 31 Mar 2022 22:45:51 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     "Russell King (Oracle)" <linux@...linux.org.uk>
Cc:     Ioana Ciornei <ioana.ciornei@....com>, davem@...emloft.net,
        kuba@...nel.org, netdev@...r.kernel.org, robh+dt@...nel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH net-next] dt-bindings: net: convert sff,sfp to dtschema

On 30/03/2022 18:51, Krzysztof Kozlowski wrote:
> On 30/03/2022 17:40, Russell King (Oracle) wrote:
>>
>>>> +
>>>> +  - | # Serdes to PHY to SFP connection
>>>> +    #include <dt-bindings/gpio/gpio.h>
>>>
>>> Are you sure it works fine? Double define?
>>
>> Err what? Sorry, I don't understand what you're saying here, please
>> explain what the issue is.
> 
> Including the same header twice causes duplicate defines, which should
> be visible when testing the binding.

I don't see such errors now, so either something changed or I confused
with something else. It should work, so let's skip my comment here.

Best regards,
Krzysztof