lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 30 Mar 2022 22:48:26 -0700 From: Jakub Kicinski <kuba@...nel.org> To: Jon Maloy <jmaloy@...hat.com> Cc: Niels Dossche <dossche.niels@...il.com>, tipc-discussion@...ts.sourceforge.net, netdev@...r.kernel.org, Ying Xue <ying.xue@...driver.com>, "David S. Miller" <davem@...emloft.net>, Paolo Abeni <pabeni@...hat.com>, Hoang Le <hoang.h.le@...tech.com.au> Subject: Re: [PATCH net] tipc: use a write lock for keepalive_intv instead of a read lock On Tue, 29 Mar 2022 18:12:14 +0200 Niels Dossche wrote: > Currently, n->keepalive_intv is written to while n is locked by a read > lock instead of a write lock. This seems to me to break the atomicity > against other readers. > Change this to a write lock instead to solve the issue. > > Note: > I am currently working on a static analyser to detect missing locks > using type-based static analysis as my master's thesis > in order to obtain my master's degree. > If you would like to have more details, please let me know. > This was a reported case. I manually verified the report by looking > at the code, so that I do not send wrong information or patches. > After concluding that this seems to be a true positive, I created > this patch. I have both compile-tested this patch and runtime-tested > this patch on x86_64. The effect on a running system could be a > potential race condition in exceptional cases. > This issue was found on Linux v5.17. > > Fixes: f5d6c3e5a359 ("tipc: fix node keep alive interval calculation") > Signed-off-by: Niels Dossche <dossche.niels@...il.com> Looks good, Jon?
Powered by blists - more mailing lists