lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 31 Mar 2022 10:11:17 +0900 From: Masami Hiramatsu <mhiramat@...nel.org> To: Alexei Starovoitov <ast@...nel.org>, Alexei Starovoitov <alexei.starovoitov@...il.com> Cc: davem@...emloft.net, daniel@...earbox.net, peterz@...radead.org, mhiramat@...nel.org, kuba@...nel.org, andrii@...nel.org, netdev@...r.kernel.org, bpf@...r.kernel.org, kernel-team@...com Subject: [PATCH bpf] rethook: Fix to use WRITE_ONCE() for rethook::handler Since the function pointered by rethook::handler never be removed when the rethook is alive, it doesn't need to use rcu_assign_pointer() to update it. Just use WRITE_ONCE(). Reported-by: Alexei Starovoitov <alexei.starovoitov@...il.com> Signed-off-by: Masami Hiramatsu <mhiramat@...nel.org> --- kernel/trace/rethook.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/trace/rethook.c b/kernel/trace/rethook.c index ab463a4d2b23..b56833700d23 100644 --- a/kernel/trace/rethook.c +++ b/kernel/trace/rethook.c @@ -65,7 +65,7 @@ static void rethook_free_rcu(struct rcu_head *head) */ void rethook_free(struct rethook *rh) { - rcu_assign_pointer(rh->handler, NULL); + WRITE_ONCE(rh->handler, NULL); call_rcu(&rh->rcu, rethook_free_rcu); }
Powered by blists - more mailing lists