netdev - Re: [PATCH net] qed: fix ethtool register dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 1 Apr 2022 13:23:26 -0600
From:   Tim Gardner <tim.gardner@...onical.com>
To:     Manish Chopra <manishc@...vell.com>, kuba@...nel.org
Cc:     netdev@...r.kernel.org, aelior@...vell.com, palok@...vell.com,
        pkushwaha@...vell.com, stable@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH net] qed: fix ethtool register dump



On 4/1/22 12:53, Manish Chopra wrote:
> To fix a coverity complain, commit d5ac07dfbd2b
> ("qed: Initialize debug string array") removed "sw-platform"
> (one of the common global parameters) from the dump as this
> was used in the dump with an uninitialized string, however
> it did not reduce the number of common global parameters
> which caused the incorrect (unable to parse) register dump
> 
> this patch fixes it with reducing NUM_COMMON_GLOBAL_PARAMS
> bye one.
> 
> Cc: stable@...r.kernel.org
> Cc: Tim Gardner <tim.gardner@...onical.com>
> Cc: "David S. Miller" <davem@...emloft.net>
> Fixes: d5ac07dfbd2b ("qed: Initialize debug string array")
> Signed-off-by: Prabhakar Kushwaha <pkushwaha@...vell.com>
> Signed-off-by: Alok Prasad <palok@...vell.com>
> Signed-off-by: Ariel Elior <aelior@...vell.com>
> Signed-off-by: Manish Chopra <manishc@...vell.com>
> ---
>   drivers/net/ethernet/qlogic/qed/qed_debug.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/qlogic/qed/qed_debug.c b/drivers/net/ethernet/qlogic/qed/qed_debug.c
> index e3edca187ddf..5250d1d1e49c 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_debug.c
> +++ b/drivers/net/ethernet/qlogic/qed/qed_debug.c
> @@ -489,7 +489,7 @@ struct split_type_defs {
>   
>   #define STATIC_DEBUG_LINE_DWORDS	9
>   
> -#define NUM_COMMON_GLOBAL_PARAMS	11
> +#define NUM_COMMON_GLOBAL_PARAMS	10
>   
>   #define MAX_RECURSION_DEPTH		10
>   

Looks good to me.

Reviewed-by: Tim Gardner <tim.gardner@...onical.com>

rtg
-- 
-----------
Tim Gardner
Canonical, Inc