netdev - Re: [PATCH net v2] rtnetlink: enable alt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1250f3a0-9ed3-cfad-ba93-6b16cad5dcf5@wifirst.fr>
Date:   Fri, 1 Apr 2022 23:02:39 +0200
From:   Florent Fourcot <florent.fourcot@...irst.fr>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, cong.wang@...edance.com,
        edumazet@...gle.com, Jiri Pirko <jiri@...lanox.com>,
        Brian Baboch <brian.baboch@...irst.fr>
Subject: Re: [PATCH net v2] rtnetlink: enable alt_ifname for setlink/newlink


> 
> This part depends on your other change, right? Do you care about this
> getting into stable? Otherwise we can downgrade it from a fix to -next
> and merge after your other patch. It never worked so we can go either
> way on it being a fix. Actually leaning slightly towards it _not_ being
> a fix.
> 

I don't really care about getting this into stable, so I will resubmit 
for net-next when opened.
Should I drop "Fixes" tag? Alternatives ifname feature never worked for 
setlink/newlink, but 76c9ac0ee878 claimed it was.


> 
> Formatting slightly off here, should be
> 
> 	} else {
> 

Thanks


> 
> How about we pass tb and extract IFLA_IFNAME and IFLA_ALT_IFNAME inside
> rtnl_dev_get()? All callers seem to pass the same args now.
> 

You are right, it's a good idea for the v3

Best regards,

-- 
Florent Fourcot