lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 2 Apr 2022 10:55:11 +0200 From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> To: Martin Faltesek <mfaltesek@...omium.org>, netdev@...r.kernel.org, kuba@...nel.org, christophe.ricard@...il.com, jordy@...ing.systems Cc: sameo@...ux.intel.com, wklin@...gle.com, groeck@...gle.com, mfaltesek@...gle.com, gregkh@...uxfoundation.org Subject: Re: [PATCH v2 1/3] nfc: st21nfca: fix incorrect validating logic in EVT_TRANSACTION On 01/04/2022 20:09, Martin Faltesek wrote: > The first validation check for EVT_TRANSACTION has two different checks > tied together with logical AND. One is a check for minimum packet length, > and the other is for a valid aid_tag. If either condition is true (fails), > then an error should be triggered. The fix is to change && to ||. > > Fixes: 26fc6c7f02cb ("NFC: st21nfca: Add HCI transaction event support") > Signed-off-by: Martin Faltesek <mfaltesek@...gle.com> > --- > drivers/nfc/st21nfca/se.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> Best regards, Krzysztof
Powered by blists - more mailing lists