netdev - Re: [PATCH] net/ethernet : set default assignment identifier to NET_NAME

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YkiYiLK+zvwiS4t+@lunn.ch>
Date:   Sat, 2 Apr 2022 20:40:08 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Ian Wienand <iwienand@...hat.com>
Cc:     netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] net/ethernet : set default assignment identifier to
 NET_NAME_ENUM

> > and we will get surprises when
> > interfaces which were not previously renamed now are? It would be nice
> > to see some justification this is actually safe to do.
> 
> I came to this through inconsistency of behaviour in a heterogeneous
> OpenStack cloud environment.  Most of the clouds are kvm-based and
> have NICS using virtio which fills in
> /sys/class/net/<interface>/name_assign_type and this bubbles up
> through udev/systemd/general magic to get the devices renamed.
> However we have one outlier using Xen and the xen-netfront driver,
> which I traced to here, where name_assign_type isn't set.

Hi Ian

So is there a risk here that Xen user suddenly find their network
interfaces renamed, where as before they were not, and their
networking thus breaks?

Consistency is good, but it is hard to do in retrospect when there are
deployed systems potentially dependent on the inconsistency.

	 Andrew