[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date: Mon, 4 Apr 2022 09:09:08 -0600
From: David Ahern <dsahern@...nel.org>
To: netdev@...r.kernel.org, kuba@...nel.org, davem@...emloft.net,
pabeni@...hat.com
Cc: Filip.Pudak@...driver.com, Jiguang.Xiao@...driver.com,
ssuryaextr@...il.com, David Ahern <dsahern@...nel.org>,
Pudak@...r.kernel.org, Xiao@...r.kernel.org
Subject: [PATCH net] ipv6: Fix stats accounting in ip6_pkt_drop
VRF devices are the loopbacks for VRFs, and a loopback can not be
assigned to a VRF. Accordingly, the condition in ip6_pkt_drop should
be '||' not '&&'.
Fixes: 1d3fd8a10bed ("vrf: Use orig netdev to count Ip6InNoRoutes and a fresh route lookup when sending dest unreach")
Reported-by: Pudak, Filip <Filip.Pudak@...driver.com>
Reported-by: Xiao, Jiguang <Jiguang.Xiao@...driver.com>
Signed-off-by: David Ahern <dsahern@...nel.org>
---
net/ipv6/route.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index 2fa10e60cccd..169e9df6d172 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -4484,7 +4484,7 @@ static int ip6_pkt_drop(struct sk_buff *skb, u8 code, int ipstats_mib_noroutes)
struct inet6_dev *idev;
int type;
- if (netif_is_l3_master(skb->dev) &&
+ if (netif_is_l3_master(skb->dev) ||
dst->dev == net->loopback_dev)
idev = __in6_dev_get_safely(dev_get_by_index_rcu(net, IP6CB(skb)->iif));
else
--
2.24.3 (Apple Git-128)
Powered by blists - more mailing lists