netdev - Re: [PATCH v2 net-next 1/2] net: tc: dsa: Add the matchall filter with drop action for bridged DSA ports.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 4 Apr 2022 17:18:30 +0800
From:   kernel test robot <lkp@...el.com>
To:     Mattias Forsblad <mattias.forsblad@...il.com>,
        netdev@...r.kernel.org
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Tobias Waldekranz <tobias@...dekranz.com>,
        Mattias Forsblad <mattias.forsblad@...il.com>
Subject: Re: [PATCH v2 net-next 1/2] net: tc: dsa: Add the matchall filter
 with drop action for bridged DSA ports.

Hi Mattias,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Mattias-Forsblad/net-tc-dsa-Implement-offload-of-matchall-for-bridged-DSA-ports/20220404-143446
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 89695196f0ba78a17453f9616355f2ca6b293402
config: arm-randconfig-r021-20220404 (https://download.01.org/0day-ci/archive/20220404/202204041711.z39NxDjM-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project c4a1b07d0979e7ff20d7d541af666d822d66b566)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # https://github.com/intel-lab-lkp/linux/commit/6781e2f5653edf4eeab1aa2996a250b942f2b19b
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Mattias-Forsblad/net-tc-dsa-Implement-offload-of-matchall-for-bridged-DSA-ports/20220404-143446
        git checkout 6781e2f5653edf4eeab1aa2996a250b942f2b19b
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash net/dsa/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> net/dsa/slave.c:1307:9: warning: variable 'err' is uninitialized when used here [-Wuninitialized]
           return err;
                  ^~~
   net/dsa/slave.c:1289:9: note: initialize the variable 'err' to silence this warning
           int err;
                  ^
                   = 0
   1 warning generated.

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for MICREL_PHY
   Depends on NETDEVICES && PHYLIB && PTP_1588_CLOCK_OPTIONAL
   Selected by
   - KS8851_MLL && NETDEVICES && ETHERNET && NET_VENDOR_MICREL && HAS_IOMEM


vim +/err +1307 net/dsa/slave.c

  1278	
  1279	static int
  1280	dsa_slave_add_cls_matchall_drop(struct net_device *dev,
  1281					struct tc_cls_matchall_offload *cls,
  1282					bool ingress)
  1283	{
  1284		struct dsa_port *dp = dsa_slave_to_port(dev);
  1285		struct dsa_slave_priv *p = netdev_priv(dev);
  1286		struct dsa_mall_tc_entry *mall_tc_entry;
  1287		struct dsa_mall_drop_tc_entry *drop;
  1288		struct dsa_switch *ds = dp->ds;
  1289		int err;
  1290	
  1291		if (!ds->ops->bridge_local_rcv)
  1292			return -EOPNOTSUPP;
  1293	
  1294		mall_tc_entry = kzalloc(sizeof(*mall_tc_entry), GFP_KERNEL);
  1295		if (!mall_tc_entry)
  1296			return -ENOMEM;
  1297	
  1298		mall_tc_entry->cookie = cls->cookie;
  1299		mall_tc_entry->type = DSA_PORT_MALL_DROP;
  1300		drop = &mall_tc_entry->drop;
  1301		drop->enable = true;
  1302		dp->bridge->local_rcv = 0;
  1303		dsa_slave_bridge_foreign_if_check(dp->bridge->dev, drop);
  1304	
  1305		list_add_tail(&mall_tc_entry->list, &p->mall_tc_list);
  1306	
> 1307		return err;
  1308	}
  1309	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp