netdev - Re: [PATCH 2/2] dt-bindings: net: qcom,ipa: finish the qcom,smp2p example

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <10d4f538-249d-f78c-b90f-298c9727d58d@ieee.org>
Date:   Mon, 4 Apr 2022 08:36:44 -0500
From:   Alex Elder <elder@...e.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Manivannan Sadhasivam <mani@...nel.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Jassi Brar <jassisinghbrar@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, Alex Elder <elder@...nel.org>,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, netdev@...r.kernel.org
Cc:     Rob Herring <robh@...nel.org>
Subject: Re: [PATCH 2/2] dt-bindings: net: qcom,ipa: finish the qcom,smp2p
 example

On 4/2/22 10:55 AM, Krzysztof Kozlowski wrote:
> The example using qcom,smp2p should have all necessary properties, to
> avoid DT schema validation warnings.

Looks good to me.  The particular values don't match any
reality, but that doesn't matter for getting the syntactic
parse to pass without error or warning.

Thanks.

Reviewed-by: Alex Elder <elder@...aro.org>

> 
> Reported-by: Rob Herring <robh@...nel.org>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
>   Documentation/devicetree/bindings/net/qcom,ipa.yaml | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> index 58ecc62adfaa..dd4bb2e74880 100644
> --- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> +++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> @@ -182,6 +182,12 @@ examples:
>   
>           smp2p-mpss {
>                   compatible = "qcom,smp2p";
> +                interrupts = <GIC_SPI 576 IRQ_TYPE_EDGE_RISING>;
> +                mboxes = <&apss_shared 6>;
> +                qcom,smem = <94>, <432>;
> +                qcom,local-pid = <0>;
> +                qcom,remote-pid = <5>;
> +
>                   ipa_smp2p_out: ipa-ap-to-modem {
>                           qcom,entry-name = "ipa";
>                           #qcom,smem-state-cells = <1>;
> @@ -193,6 +199,7 @@ examples:
>                           #interrupt-cells = <2>;
>                   };
>           };
> +
>           ipa@...0000 {
>                   compatible = "qcom,sdm845-ipa";
>