netdev - Re: [PATCH net] xfrm: Pass flowi_oif or l3mdev as oif to xfrm_dst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220405092927.GA2517843@gauss3.secunet.de>
Date:   Tue, 5 Apr 2022 11:29:27 +0200
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     David Ahern <dsahern@...nel.org>
CC:     <netdev@...r.kernel.org>, <kuba@...nel.org>, <davem@...emloft.net>,
        <pabeni@...hat.com>, <oliver.sang@...el.com>,
        <herbert@...dor.apana.org.au>
Subject: Re: [PATCH net] xfrm: Pass flowi_oif or l3mdev as oif to
 xfrm_dst_lookup

On Fri, Apr 01, 2022 at 12:58:37PM -0600, David Ahern wrote:
> The commit referenced in the Fixes tag no longer changes the
> flow oif to the l3mdev ifindex. A xfrm use case was expecting
> the flowi_oif to be the VRF if relevant and the change broke
> that test. Update xfrm_bundle_create to pass oif if set and any
> potential flowi_l3mdev if oif is not set.
> 
> Fixes: 40867d74c374 ("net: Add l3mdev index to flow struct and avoid oif reset for port devices")
> Reported-by: kernel test robot <oliver.sang@...el.com>
> Signed-off-by: David Ahern <dsahern@...nel.org>

Applied to the ipsec tree, thanks David!