netdev - Re: [PATCH RFC V1 net-next 3/4] net: Let the active time stamping layer be selectable.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220405154604.GA6509@hoboy.vegasvil.org>
Date:   Tue, 5 Apr 2022 08:46:04 -0700
From:   Richard Cochran <richardcochran@...il.com>
To:     Michael Walle <michael@...le.cc>
Cc:     Andrew Lunn <andrew@...n.ch>, davem@...emloft.net,
        grygorii.strashko@...com, kuba@...nel.org, kurt@...utronix.de,
        linux-kernel@...r.kernel.org, linux@...linux.org.uk,
        mlichvar@...hat.com, netdev@...r.kernel.org,
        qiangqing.zhang@....com, vladimir.oltean@....com,
        Horatiu Vultur <horatiu.vultur@...rochip.com>
Subject: Re: [PATCH RFC V1 net-next 3/4] net: Let the active time stamping
 layer be selectable.

On Tue, Apr 05, 2022 at 10:48:21AM +0200, Michael Walle wrote:
> Can the ethernet driver select the default one? So any current
> driver which has "if phy_has_hwtstamp() forward_ioctl;" can set
> it to PHY while newer drivers can (or should actually) leave it as
> MAC.

I want to remove all of the phy_has_ stuff from MAC drivers.
MAC/PHY drivers should just implement the in-kernel interfaces.
IMO that is the clean way forward.

Thanks,
Richard