netdev - Re: [PATCH] iwlwifi: mvm: initialize seq variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKwvOdng7CbqGrDH+WYwY0aAkjpW8mT428m4p=K8VTTD8ddV0Q@mail.gmail.com>
Date:   Tue, 5 Apr 2022 10:57:07 -0700
From:   Nick Desaulniers <ndesaulniers@...gle.com>
To:     Tom Rix <trix@...hat.com>
Cc:     luciano.coelho@...el.com, kvalo@...nel.org, davem@...emloft.net,
        kuba@...nel.org, pabeni@...hat.com, nathan@...nel.org,
        johannes.berg@...el.com, emmanuel.grumbach@...el.com,
        dan.carpenter@...cle.com, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        llvm@...ts.linux.dev
Subject: Re: [PATCH] iwlwifi: mvm: initialize seq variable

On Fri, Apr 1, 2022 at 4:06 PM Tom Rix <trix@...hat.com> wrote:
>
> Clang static analysis reports this issue
> d3.c:567:22: warning: The left operand of '>' is
>   a garbage value
>   if (seq.tkip.iv32 > cur_rx_iv32)
>       ~~~~~~~~~~~~~ ^
>
> seq is never initialized. Call ieee80211_get_key_rx_seq() to
> initialize seq.
>
> Fixes: 0419e5e672d6 ("iwlwifi: mvm: d3: separate TKIP data from key iteration")
> Signed-off-by: Tom Rix <trix@...hat.com>

Thanks for the patch!
Reviewed-by: Nick Desaulniers <ndesaulniers@...gle.com>

> ---
>  drivers/net/wireless/intel/iwlwifi/mvm/d3.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/d3.c b/drivers/net/wireless/intel/iwlwifi/mvm/d3.c
> index a995bba0ba81..9b190b3ce6c1 100644
> --- a/drivers/net/wireless/intel/iwlwifi/mvm/d3.c
> +++ b/drivers/net/wireless/intel/iwlwifi/mvm/d3.c
> @@ -563,6 +563,7 @@ static void iwl_mvm_wowlan_get_tkip_data(struct ieee80211_hw *hw,
>                 }
>
>                 for (i = 0; i < IWL_NUM_RSC; i++) {
> +                       ieee80211_get_key_rx_seq(key, i, &seq);
>                         /* wrapping isn't allowed, AP must rekey */
>                         if (seq.tkip.iv32 > cur_rx_iv32)
>                                 cur_rx_iv32 = seq.tkip.iv32;
> --
> 2.27.0
>


-- 
Thanks,
~Nick Desaulniers