netdev - Re: riscv defconfig CONFIG_PM/macb/generic PHY regression in v5.18-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0415ff44-34fd-2f00-833d-fbcea3a967cb@conchuod.ie>
Date:   Tue, 5 Apr 2022 17:58:50 +0100
From:   Conor Dooley <mail@...chuod.ie>
To:     "Russell King (Oracle)" <linux@...linux.org.uk>,
        Conor.Dooley@...rochip.com
Cc:     palmer@...osinc.com, apatel@...tanamicro.com,
        netdev@...r.kernel.org, Nicolas.Ferre@...rochip.com,
        Claudiu.Beznea@...rochip.com, andrew@...n.ch, hkallweit1@...il.com,
        linux-riscv@...ts.infradead.org
Subject: Re: riscv defconfig CONFIG_PM/macb/generic PHY regression in
 v5.18-rc1



On 05/04/2022 16:53, Russell King (Oracle) wrote:
> On Tue, Apr 05, 2022 at 01:05:12PM +0000, Conor.Dooley@...rochip.com wrote:
>> Hey,
>> I seem to have come across a regression in the default riscv defconfig
>> between riscv-for-linus-5.18-mw0 (bbde015227e8) & v5.18-rc1, exposed by
>> c5179ef1ca0c ("RISC-V: Enable RISC-V SBI CPU Idle driver for QEMU virt
>> machine") which causes the ethernet phy to not come up on my Icicle kit:
>> [ 3.179864] macb 20112000.ethernet eth0: validation of sgmii with support 0000000,00000000,00006280 and advertisement 0000000,00000000,00004280 failed: -EINVAL
>> [ 3.194490] macb 20112000.ethernet eth0: Could not attach PHY (-22)
> 
> I don't think that would be related to the idle driver. This looks like
> the PHY hasn't filled in the supported mask at probe time - do you have
> the driver for the PHY built-in or the PHY driver module loaded?

Hey Russel,
The idle stuff enabled CONFIG_PM=y though in the default riscv
defconfig, so it is not confined to just QEMU.

I am not sure what the symbol for the generic phy & I am not at work
to properly check, so I hope this is the relevant part of the config:

CONFIG_PHYLINK=y
CONFIG_PHYLIB=y
CONFIG_SWPHY=y
CONFIG_FIXED_PHY=y

If it isn't, you should be able to generate the config I used to cause
the error with:
make ARCH=RISCV defconfig

If you look at my response to Andrew [1] you'll see that my problems
are not isolated to just the Generic PHY driver as a builtin Vitesse
driver has issues too (although validation appears to have passed).

Thanks,
Conor.

[1] 
https://lore.kernel.org/linux-riscv/60fd1eb7-a2ce-9084-c567-721e975e7e86@microchip.com/