netdev - Re: [PATCH net] net: micrel: Fix KS8851 Kconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ac023638-5ce4-1c0b-29e5-e30fc3038e72@infradead.org>
Date:   Tue, 5 Apr 2022 11:04:51 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Horatiu Vultur <horatiu.vultur@...rochip.com>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
        Divya.Koppera@...rochip.com, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH net] net: micrel: Fix KS8851 Kconfig



On 4/4/22 23:59, Horatiu Vultur wrote:
> KS8851 selects MICREL_PHY, which depends on PTP_1588_CLOCK_OPTIONAL, so
> make KS8851 also depend on PTP_1588_CLOCK_OPTIONAL.
> 
> Fixes kconfig warning and build errors:
> 
> WARNING: unmet direct dependencies detected for MICREL_PHY
>   Depends on [m]: NETDEVICES [=y] && PHYLIB [=y] && PTP_1588_CLOCK_OPTIONAL [=m]
>     Selected by [y]:
>       - KS8851 [=y] && NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_MICREL [=y] && SPI [=y]
> 
> ld.lld: error: undefined symbol: ptp_clock_register referenced by micrel.c
> net/phy/micrel.o:(lan8814_probe) in archive drivers/built-in.a
> ld.lld: error: undefined symbol: ptp_clock_index referenced by micrel.c
> net/phy/micrel.o:(lan8814_ts_info) in archive drivers/built-in.a
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Fixes: ece19502834d ("net: phy: micrel: 1588 support for LAN8814 phy")
> Signed-off-by: Horatiu Vultur <horatiu.vultur@...rochip.com>

Tested-by: Randy Dunlap <rdunlap@...radead.org>
Acked-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

> ---
>  drivers/net/ethernet/micrel/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/micrel/Kconfig b/drivers/net/ethernet/micrel/Kconfig
> index 1b632cdd7630..830363bafcce 100644
> --- a/drivers/net/ethernet/micrel/Kconfig
> +++ b/drivers/net/ethernet/micrel/Kconfig
> @@ -28,6 +28,7 @@ config KS8842
>  config KS8851
>  	tristate "Micrel KS8851 SPI"
>  	depends on SPI
> +	depends on PTP_1588_CLOCK_OPTIONAL
>  	select MII
>  	select CRC32
>  	select EEPROM_93CX6

-- 
~Randy