netdev - Re: [PATCH net-next] net: wan: remove the lanmedia (lmc) driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220406111101.GA19718@alpha.franken.de>
Date:   Wed, 6 Apr 2022 13:11:01 +0200
From:   Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, pabeni@...hat.com, netdev@...r.kernel.org,
        Krzysztof Hałasa <khalasa@...p.pl>,
        Andrew Stanley-Jones <asj@...n.com>,
        Rob Braun <bbraun@....com>, Michael Graff <explorer@....com>,
        Matt Thomas <matt@...-software.com>,
        Arnd Bergmann <arnd@...nel.org>, linux-mips@...r.kernel.org,
        linus.walleij@...aro.org
Subject: Re: [PATCH net-next] net: wan: remove the lanmedia (lmc) driver

On Tue, Apr 05, 2022 at 09:15:48PM -0700, Jakub Kicinski wrote:
> The driver for LAN Media WAN interfaces spews build warnings on
> microblaze. The virt_to_bus() calls discard the volatile keyword.
> The right thing to do would be to migrate this driver to a modern
> DMA API but it seems unlikely anyone is actually using it.
> There had been no fixes or functional changes here since
> the git era begun.
> 
> Let's remove this driver, there isn't much changing in the APIs,
> if users come forward we can apologize and revert.
> 
> Link: https://lore.kernel.org/all/20220321144013.440d7fc0@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com/
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: Krzysztof Hałasa <khalasa@...p.pl>
> CC: Andrew Stanley-Jones <asj@...n.com>
> CC: Rob Braun <bbraun@....com>
> CC: Michael Graff <explorer@....com>,
> CC: Matt Thomas <matt@...-software.com>
> CC: Arnd Bergmann <arnd@...nel.org>
> CC: tsbogend@...ha.franken.de # MIPS
> CC: linux-mips@...r.kernel.org
> CC: linus.walleij@...aro.org
> ---
>  arch/mips/configs/gpr_defconfig  |    1 -
>  arch/mips/configs/mtx1_defconfig |    1 -
>  drivers/net/wan/Kconfig          |   28 -
>  drivers/net/wan/Makefile         |    2 -
>  drivers/net/wan/lmc/Makefile     |   18 -
>  drivers/net/wan/lmc/lmc.h        |   33 -
>  drivers/net/wan/lmc/lmc_debug.c  |   65 -
>  drivers/net/wan/lmc/lmc_debug.h  |   52 -
>  drivers/net/wan/lmc/lmc_ioctl.h  |  255 ----
>  drivers/net/wan/lmc/lmc_main.c   | 2009 ------------------------------
>  drivers/net/wan/lmc/lmc_media.c  | 1206 ------------------
>  drivers/net/wan/lmc/lmc_proto.c  |  106 --
>  drivers/net/wan/lmc/lmc_proto.h  |   18 -
>  drivers/net/wan/lmc/lmc_var.h    |  468 -------
>  14 files changed, 4262 deletions(-)
>  delete mode 100644 drivers/net/wan/lmc/Makefile
>  delete mode 100644 drivers/net/wan/lmc/lmc.h
>  delete mode 100644 drivers/net/wan/lmc/lmc_debug.c
>  delete mode 100644 drivers/net/wan/lmc/lmc_debug.h
>  delete mode 100644 drivers/net/wan/lmc/lmc_ioctl.h
>  delete mode 100644 drivers/net/wan/lmc/lmc_main.c
>  delete mode 100644 drivers/net/wan/lmc/lmc_media.c
>  delete mode 100644 drivers/net/wan/lmc/lmc_proto.c
>  delete mode 100644 drivers/net/wan/lmc/lmc_proto.h
>  delete mode 100644 drivers/net/wan/lmc/lmc_var.h

Acked-by: Thomas Bogendoerfer <tsbogend@...ha.franken.de>

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]