netdev - Re: [PATCH net-next] net: mvneta: add support for page_pool_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yk2QFmvQOSiL8WKH@lore-desk>
Date:   Wed, 6 Apr 2022 15:05:26 +0200
From:   Lorenzo Bianconi <lorenzo@...nel.org>
To:     Ilias Apalodimas <ilias.apalodimas@...aro.org>
Cc:     Andrew Lunn <andrew@...n.ch>, netdev@...r.kernel.org,
        lorenzo.bianconi@...hat.com, davem@...emloft.net, kuba@...nel.org,
        pabeni@...hat.com, thomas.petazzoni@...tlin.com,
        linux@...linux.org.uk, jbrouer@...hat.com, jdamato@...tly.com
Subject: Re: [PATCH net-next] net: mvneta: add support for page_pool_get_stats

> Hi Andrew
> 
> On Wed, 6 Apr 2022 at 15:49, Andrew Lunn <andrew@...n.ch> wrote:
> >
> > On Tue, Apr 05, 2022 at 10:32:12PM +0200, Lorenzo Bianconi wrote:
> > > Introduce support for the page_pool_get_stats API to mvneta driver.
> > > If CONFIG_PAGE_POOL_STATS is enabled, ethtool will report page pool
> > > stats.
> >
> > Hi Lorenzo
> >
> > There are a lot of #ifdef in this patch. They are generally not
> > liked. What does the patch actually depend on? mnveta has a select
> > PAGE_POOL so the page pool itself should always be available?
> 
> The stats are on a different Kconfig since we wanted to allow people
> opt out if they were worried about performance.  However this is not a
> 10gbit interface and I doubt there will be any measurable hit.  I
> think selecting PAGE_POOL_STATS for the driver makes sense and will
> make the code easier to follow.

Hi Andrew and Ilias,

I just kept the same approach used for mlx driver but I am fine to always
select PAGE_POOL_STATS for mvneta. I will fix it in v2.

Regards,
Lorenzo

> 
> Thanks
> /Ilias
> >
> >           Andrew

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)