netdev - Re: [PATCH net-next] net: mvneta: add support for page_pool_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 6 Apr 2022 14:49:51 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Lorenzo Bianconi <lorenzo@...nel.org>
Cc:     netdev@...r.kernel.org, lorenzo.bianconi@...hat.com,
        davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
        thomas.petazzoni@...tlin.com, linux@...linux.org.uk,
        jbrouer@...hat.com, ilias.apalodimas@...aro.org, jdamato@...tly.com
Subject: Re: [PATCH net-next] net: mvneta: add support for page_pool_get_stats

On Tue, Apr 05, 2022 at 10:32:12PM +0200, Lorenzo Bianconi wrote:
> Introduce support for the page_pool_get_stats API to mvneta driver.
> If CONFIG_PAGE_POOL_STATS is enabled, ethtool will report page pool
> stats.

Hi Lorenzo

There are a lot of #ifdef in this patch. They are generally not
liked. What does the patch actually depend on? mnveta has a select
PAGE_POOL so the page pool itself should always be available?

	  Andrew