netdev - Re: [PATCH bpf-next v3 07/27] bpf: selftests: Set libbpf 1.0 API mode explicitly in get_cgroup_id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <82b87aee-09c2-fbad-7613-4e298bcb3431@quicinc.com>
Date:   Tue, 5 Apr 2022 13:46:58 -0700
From:   Jeff Johnson <quic_jjohnson@...cinc.com>
To:     Yafang Shao <laoar.shao@...il.com>, <andrii@...nel.org>,
        <ast@...nel.org>, <daniel@...earbox.net>, <kafai@...com>,
        <songliubraving@...com>, <yhs@...com>, <john.fastabend@...il.com>,
        <kpsingh@...nel.org>, <shuah@...nel.org>
CC:     <netdev@...r.kernel.org>, <bpf@...r.kernel.org>,
        <linux-kselftest@...r.kernel.org>
Subject: Re: [PATCH bpf-next v3 07/27] bpf: selftests: Set libbpf 1.0 API mode
 explicitly in get_cgroup_id_user

On 4/5/2022 6:08 AM, Yafang Shao wrote:
> Let's set libbpf 1.0 API mode explicitly, then we can get rid of the
> included bpf_rlimit.h.
> 
> Signed-off-by: Yafang Shao <laoar.shao@...il.com>
> ---
>   tools/testing/selftests/bpf/test_dev_cgroup.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/bpf/test_dev_cgroup.c b/tools/testing/selftests/bpf/test_dev_cgroup.c

patch subject should refer to test_dev_cgroup
(currently has same subject as 05/27)

> index c299d3452695..7886265846a0 100644
> --- a/tools/testing/selftests/bpf/test_dev_cgroup.c
> +++ b/tools/testing/selftests/bpf/test_dev_cgroup.c
> @@ -15,7 +15,6 @@
>   
>   #include "cgroup_helpers.h"
>   #include "testing_helpers.h"
> -#include "bpf_rlimit.h"
>   
>   #define DEV_CGROUP_PROG "./dev_cgroup.o"
>   
> @@ -28,6 +27,9 @@ int main(int argc, char **argv)
>   	int prog_fd, cgroup_fd;
>   	__u32 prog_cnt;
>   
> +	/* Use libbpf 1.0 API mode */
> +	libbpf_set_strict_mode(LIBBPF_STRICT_ALL);
> +
>   	if (bpf_prog_test_load(DEV_CGROUP_PROG, BPF_PROG_TYPE_CGROUP_DEVICE,
>   			  &obj, &prog_fd)) {
>   		printf("Failed to load DEV_CGROUP program\n");