netdev - Re: [PATCH net] flow_dissector: fix false-positive __read_overflow2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202204061435.69D056F@keescook>
Date:   Wed, 6 Apr 2022 14:36:14 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, pabeni@...hat.com, netdev@...r.kernel.org,
        gustavoars@...nel.org, kurt@...utronix.de
Subject: Re: [PATCH net] flow_dissector: fix false-positive
 __read_overflow2_field() warning

On Wed, Apr 06, 2022 at 02:15:21PM -0700, Jakub Kicinski wrote:
> Bounds checking is unhappy that we try to copy both Ethernet
> addresses but pass pointer to the first one. Luckily destination
> address is the first field so pass the pointer to the entire header,
> whatever.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Ah yes, thanks! I had prepared this patch last week, but failed to
actually send it. :|

Reviewed-by: Kees Cook <keescook@...omium.org>

-- 
Kees Cook