netdev - Re: [PATCH 1/1] net/rds: Use "unpin_user_page" as "pin_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 6 Apr 2022 14:52:21 -0700
From:   Sharath Srinivasan <sharath.srinivasan@...cle.com>
To:     Gerd Rausch <gerd.rausch@...cle.com>, santosh.shilimkar@...cle.com,
        davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
        netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
        rds-devel@....oracle.com
Subject: Re: [PATCH 1/1] net/rds: Use "unpin_user_page" as "pin_user_pages"
 counterpart

On 4/6/22 14:03, Gerd Rausch wrote:

> In cases where "pin_user_pages" was used to obtain longerm references,
> the pages must be released with "unpin_user_pages".
>
> Fixes: 0d4597c8c5ab ("net/rds: Track user mapped pages through special API")
> Signed-off-by: Gerd Rausch <gerd.rausch@...cle.com>
Reviewed-by: Sharath Srinivasan <sharath.srinivasan@...cle.com>

Regards,
Sharath
> ---
>   net/rds/ib_rdma.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/net/rds/ib_rdma.c b/net/rds/ib_rdma.c
> index 8f070ee7e742..9d86d6db98c4 100644
> --- a/net/rds/ib_rdma.c
> +++ b/net/rds/ib_rdma.c
> @@ -256,8 +256,7 @@ void __rds_ib_teardown_mr(struct rds_ib_mr *ibmr)
>   			/* FIXME we need a way to tell a r/w MR
>   			 * from a r/o MR */
>   			WARN_ON(!page->mapping && irqs_disabled());
> -			set_page_dirty(page);
> -			put_page(page);
> +			unpin_user_pages_dirty_lock(&page, 1, true);
>   		}
>   		kfree(ibmr->sg);
>   
>