netdev - Re: [PATCH net] net: mdio: don't defer probe forever if PHY IRQ provider is missing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220406231956.nwe6kb6vgli2chln@skbuf>
Date:   Wed, 6 Apr 2022 23:19:57 +0000
From:   Vladimir Oltean <vladimir.oltean@....com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        "David S. Miller" <davem@...emloft.net>,
        Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        Florian Fainelli <f.fainelli@...il.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Robin Murphy <robin.murphy@....com>
Subject: Re: [PATCH net] net: mdio: don't defer probe forever if PHY IRQ
 provider is missing

On Wed, Apr 06, 2022 at 03:34:43PM -0700, Jakub Kicinski wrote:
> On Wed,  6 Apr 2022 23:23:23 +0300 Vladimir Oltean wrote:
> > diff --git a/drivers/net/mdio/fwnode_mdio.c b/drivers/net/mdio/fwnode_mdio.c
> > index 1becb1a731f6..1c1584fca632 100644
> > --- a/drivers/net/mdio/fwnode_mdio.c
> > +++ b/drivers/net/mdio/fwnode_mdio.c
> > @@ -43,6 +43,11 @@ int fwnode_mdiobus_phy_device_register(struct mii_bus *mdio,
> >  	int rc;
> >  
> >  	rc = fwnode_irq_get(child, 0);
> > +	/* Don't wait forever if the IRQ provider doesn't become available,
> > +	 * just fall back to poll mode
> > +	 */
> > +	if (rc == -EPROBE_DEFER)
> > +		rc = driver_deferred_probe_check_state(&phy->mdio.dev);
> 
> This one's not exported, allmodconfig build fails.

Oops, I didn't realize that all its callers except for FWNODE_MDIO are built-in.

Do you prefer me exporting the symbol as part of the same patch or a different one?