netdev - Re: [PATCH] mlxsw: spectrum_router: simplify list unwinding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 5 Apr 2022 13:23:53 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Ido Schimmel <idosch@...sch.org>
Cc:     Tom Rix <trix@...hat.com>, idosch@...dia.com, petrm@...dia.com,
        davem@...emloft.net, pabeni@...hat.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mlxsw: spectrum_router: simplify list unwinding

On Sun, 3 Apr 2022 16:10:19 +0300 Ido Schimmel wrote:
> On Sat, Apr 02, 2022 at 08:15:16AM -0400, Tom Rix wrote:
> > The setting of i here
> > err_nexthop6_group_get:
> > 	i = nrt6;
> > Is redundant, i is already nrt6.  So remove
> > this statement.
> > 
> > The for loop for the unwinding
> > err_rt6_create:
> > 	for (i--; i >= 0; i--) {
> > Is equivelent to
> > 	for (; i > 0; i--) {
> > 
> > Two consecutive labels can be reduced to one.
> > 
> > Signed-off-by: Tom Rix <trix@...hat.com>  
> 
> For net-next:
> 
> Reviewed-by: Ido Schimmel <idosch@...dia.com>

Now 6f2f36e5f932 ("mlxsw: spectrum_router: simplify list unwinding")
Thanks!