netdev - Re: [PATCH v3 net-next 1/4] rtnetlink: enable alt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220405174149.39a50448@kernel.org>
Date:   Tue, 5 Apr 2022 17:41:49 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Florent Fourcot <florent.fourcot@...irst.fr>
Cc:     netdev@...r.kernel.org, cong.wang@...edance.com,
        edumazet@...gle.com, Jiri Pirko <jiri@...lanox.com>,
        Brian Baboch <brian.baboch@...irst.fr>
Subject: Re: [PATCH v3 net-next 1/4] rtnetlink: enable alt_ifname for
 setlink/newlink

On Tue,  5 Apr 2022 15:42:34 +0200 Florent Fourcot wrote:
> buffer called "ifname" given in function rtnl_dev_get
> is always valid when called by setlink/newlink,
> but contains only empty string when IFLA_IFNAME is not given. So
> IFLA_ALT_IFNAME is always ignored
> 
> This patch fixes rtnl_dev_get function with a remove of ifname argument,
> and move ifname copy in do_setlink when required.
> 
> It extends feature of commit 76c9ac0ee878,
> "net: rtnetlink: add possibility to use alternative names as message
> handle""
> 
> Changes in v2:
>  * Remove ifname argument in rtnl_dev_get/do_setlink
>    functions (simplify code)
> 
> Changes in v3:
>  * Simplify rtnl_dev_get signature
> 
> CC: Jiri Pirko <jiri@...lanox.com>
> Signed-off-by: Florent Fourcot <florent.fourcot@...irst.fr>
> Signed-off-by: Brian Baboch <brian.baboch@...irst.fr>

This patch needs to be after patch 3, AFAICT. Otherwise someone running
a bisection and landing in between the two will have a buggy build.

Please provide a cover letter for the series, now that it's 4 patches.