lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 6 Apr 2022 10:20:46 +0200 From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> To: Felix Fietkau <nbd@....name>, netdev@...r.kernel.org, Rob Herring <robh+dt@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Matthias Brugger <matthias.bgg@...il.com>, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Lorenzo Bianconi <lorenzo@...nel.org> Cc: devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2 05/14] dt-bindings: arm: mediatek: document the pcie mirror node on MT7622 On 05/04/2022 21:57, Felix Fietkau wrote: > From: Lorenzo Bianconi <lorenzo@...nel.org> > > This patch adds the pcie mirror document bindings for MT7622 SoC. > The feature is used for intercepting PCIe MMIO access for the WED core > Add related info in mediatek-net bindings. > > Signed-off-by: Lorenzo Bianconi <lorenzo@...nel.org> > Signed-off-by: Felix Fietkau <nbd@....name> > --- > .../mediatek/mediatek,mt7622-pcie-mirror.yaml | 42 +++++++++++++++++++ Eh, I wanted to ask to not put it inside arm/, but judging by your usage - you did not create drivers for both of these (WED and PCIe mirror). You only need them to expose address spaces via syscon. This actually looks hacky. Either WED and PCIe mirror are part of network driver, then add the address spaces via "reg". If they are not, but instead they are separate blocks, why you don't have drivers for them? Best regards, Krzysztof
Powered by blists - more mailing lists