[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20220407100646.049467af@xps13>
Date: Thu, 7 Apr 2022 10:06:46 +0200
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Alexander Aring <alex.aring@...il.com>
Cc: Stefan Schmidt <stefan@...enfreihafen.org>,
linux-wpan - ML <linux-wpan@...r.kernel.org>,
"David S. Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>,
"open list:NETWORKING [GENERAL]" <netdev@...r.kernel.org>,
David Girault <david.girault@...vo.com>,
Romuald Despres <romuald.despres@...vo.com>,
Frederic Blain <frederic.blain@...vo.com>,
Nicolas Schodet <nico@...fr.eu.org>,
Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH v5 09/11] net: ieee802154: atusb: Call _xmit_error()
when a transmission fails
Hi Alexander,
alex.aring@...il.com wrote on Wed, 6 Apr 2022 17:58:59 -0400:
> Hi,
>
> On Wed, Apr 6, 2022 at 11:34 AM Miquel Raynal <miquel.raynal@...tlin.com> wrote:
> >
> > ieee802154_xmit_error() is the right helper to call when a transmission
> > has failed. Let's use it instead of open-coding it.
> >
> > Signed-off-by: Miquel Raynal <miquel.raynal@...tlin.com>
> > ---
> > drivers/net/ieee802154/atusb.c | 5 ++---
> > 1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/net/ieee802154/atusb.c b/drivers/net/ieee802154/atusb.c
> > index f27a5f535808..d04db4d07a64 100644
> > --- a/drivers/net/ieee802154/atusb.c
> > +++ b/drivers/net/ieee802154/atusb.c
> > @@ -271,9 +271,8 @@ static void atusb_tx_done(struct atusb *atusb, u8 seq)
> > * unlikely case now that seq == expect is then true, but can
> > * happen and fail with a tx_skb = NULL;
> > */
> > - ieee802154_wake_queue(atusb->hw);
> > - if (atusb->tx_skb)
> > - dev_kfree_skb_irq(atusb->tx_skb);
> > + ieee802154_xmit_error(atusb->hw, atusb->tx_skb,
> > + IEEE802154_SYSTEM_ERROR);
>
> That should then call the xmit_error for ANY other reason which is not
> 802.15.4 specific which is the bus_error() function?
I'll drop the bus error function so we can stick to a regular
_xmit_error() call.
Besides, we do not have any trac information nor any easy access to
what failed exactly, so it's probably best anyway.
Thanks,
Miquèl
Powered by blists - more mailing lists