netdev - Re: [PATCH v2] net: phy: micrel: ksz9031/ksz9131: add cabletest support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <57ef40a8-c74d-aafa-f49c-27e722254587@denx.de>
Date:   Thu, 7 Apr 2022 12:56:27 +0200
From:   Marek Vasut <marex@...x.de>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
        "David S . Miller" <davem@...emloft.net>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Oleksij Rempel <linux@...pel-privat.de>,
        Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH v2] net: phy: micrel: ksz9031/ksz9131: add cabletest
 support

On 4/7/22 06:57, Jakub Kicinski wrote:
> On Thu,  7 Apr 2022 04:08:12 +0200 Marek Vasut wrote:
>> Add cable test support for Micrel KSZ9x31 PHYs.
>>
>> Tested on i.MX8M Mini with KSZ9131RNX in 100/Full mode with pairs shuffled
>> before magnetics:
>> (note: Cable test started/completed messages are omitted)
>>
>>    mx8mm-ksz9131-a-d-connected$ ethtool --cable-test eth0
>>    Pair A code OK
>>    Pair B code Short within Pair
>>    Pair B, fault length: 0.80m
>>    Pair C code Short within Pair
>>    Pair C, fault length: 0.80m
>>    Pair D code OK
>>
>>    mx8mm-ksz9131-a-b-connected$ ethtool --cable-test eth0
>>    Pair A code OK
>>    Pair B code OK
>>    Pair C code Short within Pair
>>    Pair C, fault length: 0.00m
>>    Pair D code Short within Pair
>>    Pair D, fault length: 0.00m
>>
>> Tested on R8A77951 Salvator-XS with KSZ9031RNX and all four pairs connected:
>> (note: Cable test started/completed messages are omitted)
>>
>>    r8a7795-ksz9031-all-connected$ ethtool --cable-test eth0
>>    Pair A code OK
>>    Pair B code OK
>>    Pair C code OK
>>    Pair D code OK
>>
>> The CTRL1000 CTL1000_ENABLE_MASTER and CTL1000_AS_MASTER bits are not
>> restored by calling phy_init_hw(), they must be manually cached in
>> ksz9x31_cable_test_start() and restored at the end of
>> ksz9x31_cable_test_get_status().
>>
>> Signed-off-by: Marek Vasut <marex@...x.de>
> 
> It does not apply completely cleanly to net-next, could you rebase?

Done, v3 is out.