[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20220407122559.27515-5-florent.fourcot@wifirst.fr>
Date: Thu, 7 Apr 2022 14:25:59 +0200
From: Florent Fourcot <florent.fourcot@...irst.fr>
To: netdev@...r.kernel.org
Cc: cong.wang@...edance.com, edumazet@...gle.com,
Florent Fourcot <florent.fourcot@...irst.fr>,
Brian Baboch <brian.baboch@...irst.fr>
Subject: [PATCH v3 net-next 4/4] rtnetlink: return EINVAL when request cannot succeed
A request without interface name/interface index/interface group cannot
work. We should return EINVAL
Signed-off-by: Florent Fourcot <florent.fourcot@...irst.fr>
Signed-off-by: Brian Baboch <brian.baboch@...irst.fr>
---
net/core/rtnetlink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index d2164bc635d3..a9a0762eaa1a 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -3420,7 +3420,7 @@ static int __rtnl_newlink(struct sk_buff *skb, struct nlmsghdr *nlh,
return rtnl_group_changelink(skb, net,
nla_get_u32(tb[IFLA_GROUP]),
ifm, extack, tb);
- return -ENODEV;
+ return -EINVAL;
}
if (tb[IFLA_MAP] || tb[IFLA_PROTINFO])
--
2.30.2
Powered by blists - more mailing lists