netdev - Re: [PATCH net-next 5/9] net: dsa: mt7530: only indicate linkmodes that can be supported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yk75boz1dIWy5jhn@shell.armlinux.org.uk>
Date:   Thu, 7 Apr 2022 15:47:10 +0100
From:   "Russell King (Oracle)" <linux@...linux.org.uk>
To:     Marek Behún <kabel@...nel.org>
Cc:     Jakub Kicinski <kuba@...nel.org>,
        Landen Chao <Landen.Chao@...iatek.com>,
        DENG Qingfang <dqfext@...il.com>,
        Sean Wang <sean.wang@...iatek.com>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Paolo Abeni <pabeni@...hat.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH net-next 5/9] net: dsa: mt7530: only indicate linkmodes
 that can be supported

On Wed, Apr 06, 2022 at 10:34:43PM +0200, Marek Behún wrote:
> On Wed, 6 Apr 2022 11:52:50 -0700
> Jakub Kicinski <kuba@...nel.org> wrote:
> 
> > On Wed, 06 Apr 2022 11:48:57 +0100 Russell King (Oracle) wrote:
> > > -	if (state->interface != PHY_INTERFACE_MODE_MII) {
> > > +	if (state->interface != PHY_INTERFACE_MODE_MII &&
> > > +	    state->interface != PHY_INTERFACE_MODE_2500BASEX)
> > >  		phylink_set(mask, 1000baseT_Full);
> > >  		phylink_set(mask, 1000baseX_Full);
> > >  	}  
> > 
> > Missing { here. Dunno if kbuild bot told you already.
> 
> Probably not, because next patch removes this code entirely :)

kbuild bot normally does catch these if I've missed them locally, but
I find the bot is very very sporadic. Thanks for spotting it.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!