lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20220407154956.GO2120790@nvidia.com>
Date:   Thu, 7 Apr 2022 12:49:56 -0300
From:   Jason Gunthorpe <jgg@...dia.com>
To:     Max Gurtovoy <mgurtovoy@...dia.com>
Cc:     Ariel Elior <aelior@...vell.com>, Anna Schumaker <anna@...nel.org>,
        Jens Axboe <axboe@...com>,
        Christian Benvenuti <benve@...co.com>,
        Potnuri Bharat Teja <bharat@...lsio.com>,
        Bernard Metzler <bmt@...ich.ibm.com>,
        Bart Van Assche <bvanassche@....org>,
        Chuck Lever <chuck.lever@...cle.com>,
        "David S. Miller" <davem@...emloft.net>,
        Dennis Dalessandro <dennis.dalessandro@...nelisnetworks.com>,
        Christoph Hellwig <hch@....de>,
        Keith Busch <kbusch@...nel.org>,
        Chaitanya Kulkarni <kch@...dia.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Leon Romanovsky <leon@...nel.org>, linux-cifs@...r.kernel.org,
        linux-nfs@...r.kernel.org, linux-nvme@...ts.infradead.org,
        linux-rdma@...r.kernel.org,
        Mike Marciniszyn <mike.marciniszyn@...nelisnetworks.com>,
        Michal Kalderon <mkalderon@...vell.com>,
        Mustafa Ismail <mustafa.ismail@...el.com>,
        Nelson Escobar <neescoba@...co.com>, netdev@...r.kernel.org,
        Paolo Abeni <pabeni@...hat.com>, rds-devel@....oracle.com,
        Sagi Grimberg <sagi@...mberg.me>,
        samba-technical@...ts.samba.org,
        Santosh Shilimkar <santosh.shilimkar@...cle.com>,
        Selvin Xavier <selvin.xavier@...adcom.com>,
        Steve French <sfrench@...ba.org>,
        Shiraz Saleem <shiraz.saleem@...el.com>,
        target-devel@...r.kernel.org,
        Trond Myklebust <trond.myklebust@...merspace.com>,
        Yishai Hadas <yishaih@...dia.com>,
        Zhu Yanjun <zyjzyj2000@...il.com>
Subject: Re: [PATCH v2] RDMA: Split kernel-only global device caps from
 uverbs device caps

On Thu, Apr 07, 2022 at 10:09:04AM +0300, Max Gurtovoy wrote:
> 
> On 4/7/2022 12:54 AM, Jason Gunthorpe wrote:
> > On Thu, Apr 07, 2022 at 12:01:44AM +0300, Max Gurtovoy wrote:
> > 
> > > > @@ -267,59 +258,53 @@ enum ib_device_cap_flags {
> > > >    	 * stag.
> > > >    	 */
> > > >    	IB_DEVICE_MEM_MGT_EXTENSIONS = IB_UVERBS_DEVICE_MEM_MGT_EXTENSIONS,
> > > MEM_MGT_EXTENSIONS is used also in the kernel ULPs (storage)
> > It is not about where it is used, it is about if it is part of the
> > uapi or not. Cleanly separating uapi from not uapi
> 
> from the commit message:
> 
> "
> 
> This cleanly splits out the uverbs flags from the kernel flags to avoid
> confusion in the flags bitmap.
> 
> "
> 
> so it was not clear, at least to me, that some user flags are part of both
> the uapi and the kapi.

I tidied it a bit:

 Split out flags from ib_device::device_cap_flags that are only used
 internally to the kernel into kernel_cap_flags that is not part of the
 uapi. This limits the device_cap_flags to being the same bitmap that will
 be copied to userspace.

Thanks,
Jason

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ