netdev - Re: [PATCH v3 net-next 1/4] rtnetlink: enable alt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220407091119.6ff5b879@kernel.org>
Date:   Thu, 7 Apr 2022 09:11:19 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Florent Fourcot <florent.fourcot@...irst.fr>
Cc:     netdev@...r.kernel.org, cong.wang@...edance.com,
        edumazet@...gle.com, Jiri Pirko <jiri@...lanox.com>,
        Brian Baboch <brian.baboch@...irst.fr>
Subject: Re: [PATCH v3 net-next 1/4] rtnetlink: enable alt_ifname for
 setlink/newlink

On Thu, 7 Apr 2022 14:34:33 +0200 Florent Fourcot wrote:
> > This patch needs to be after patch 3, AFAICT. Otherwise someone running
> > a bisection and landing in between the two will have a buggy build.
> 
> I double checked and this patch compiles perfectly fine when applied 
> first, at least with my .config.
> Could you be more specific on what I'm missing?

rtnl_group_changelink() was passing NULL as ifname, but with just 
this patch applied we'll start using tb[IFLA_IFNAME] directly. 

It's better to have your patch which rejects group settings with
tb[IFLA_IFNAME] first, to avoid changing the group + IFLA_IFNAME
behavior subtly multiple times.