[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20220407165247.1817188-1-anthony.l.nguyen@intel.com>
Date: Thu, 7 Apr 2022 09:52:42 -0700
From: Tony Nguyen <anthony.l.nguyen@...el.com>
To: davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com
Cc: Tony Nguyen <anthony.l.nguyen@...el.com>, netdev@...r.kernel.org,
alexandr.lobakin@...el.com
Subject: [PATCH net-next 0/5][pull request] 100GbE Intel Wired LAN Driver Updates 2022-04-07
Alexander Lobakin says:
This hunts down several places around packet templates/dummies for
switch rules which are either repetitive, fragile or just not
really readable code.
It's a common need to add new packet templates and to review such
changes as well, try to simplify both with the help of a pair
macros and aliases.
ice_find_dummy_packet() became very complex at this point with tons
of nested if-elses. It clearly showed this approach does not scale,
so convert its logics to the simple mask-match + static const array.
bloat-o-meter is happy about that (built w/ LLVM 13):
add/remove: 0/1 grow/shrink: 1/1 up/down: 2/-1058 (-1056)
Function old new delta
ice_fill_adv_dummy_packet 289 291 +2
ice_adv_add_update_vsi_list 201 - -201
ice_add_adv_rule 2950 2093 -857
Total: Before=414512, After=413456, chg -0.25%
add/remove: 53/52 grow/shrink: 0/0 up/down: 4660/-3988 (672)
RO Data old new delta
ice_dummy_pkt_profiles - 672 +672
Total: Before=37895, After=38567, chg +1.77%
Diffstat also looks nice, and adding new packet templates now takes
less lines.
We'll probably come out with dynamic template crafting in a while,
but for now let's improve what we have currently.
The following are changes since commit e8bd70250a821edb541c3abe1eacdad9f8dc7adf:
prestera: acl: add action hw_stats support
and are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue 100GbE
Alexander Lobakin (5):
ice: switch: add and use u16[] aliases to ice_adv_lkup_elem::{h, m}_u
ice: switch: unobscurify bitops loop in ice_fill_adv_dummy_packet()
ice: switch: use a struct to pass packet template params
ice: switch: use convenience macros to declare dummy pkt templates
ice: switch: convert packet template match code to rodata
drivers/net/ethernet/intel/ice/ice_switch.c | 489 ++++++++------------
drivers/net/ethernet/intel/ice/ice_switch.h | 12 +-
2 files changed, 211 insertions(+), 290 deletions(-)
--
2.31.1
Powered by blists - more mailing lists