netdev - Re: [PATCH net] net: mdio: don't defer probe forever if PHY IRQ provider is missing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yk51TIeGfFmfusQL@kroah.com>
Date:   Thu, 7 Apr 2022 07:23:24 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Vladimir Oltean <vladimir.oltean@....com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        "David S. Miller" <davem@...emloft.net>,
        Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        Florian Fainelli <f.fainelli@...il.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Robin Murphy <robin.murphy@....com>
Subject: Re: [PATCH net] net: mdio: don't defer probe forever if PHY IRQ
 provider is missing

On Wed, Apr 06, 2022 at 05:25:50PM -0700, Jakub Kicinski wrote:
> On Wed, 6 Apr 2022 23:19:57 +0000 Vladimir Oltean wrote:
> > On Wed, Apr 06, 2022 at 03:34:43PM -0700, Jakub Kicinski wrote:
> > > > +	if (rc == -EPROBE_DEFER)
> > > > +		rc = driver_deferred_probe_check_state(&phy->mdio.dev);
> > > This one's not exported, allmodconfig build fails.  
> > 
> > Oops, I didn't realize that all its callers except for FWNODE_MDIO are built-in.
> > 
> > Do you prefer me exporting the symbol as part of the same patch or a different one?
> 
> I presume single patch is fine, but driver_deferred_probe_check_state()
> lives in Greg's realm, so let's add Greg in case he prefers a separate
> patch or more.

separate patch that I can NAK as I do not understand why this is needed
at all :)

thanks,

greg k-h