netdev - Re: [PATCH -next 2/2] ath9k: Remove unnecessary print function dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87h77394g0.fsf@toke.dk>
Date:   Fri, 08 Apr 2022 13:53:35 +0200
From:   Toke Høiland-Jørgensen <toke@...e.dk>
To:     Yang Li <yang.lee@...ux.alibaba.com>, kvalo@...nel.org
Cc:     davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
        loic.poulain@...aro.org, wcn36xx@...ts.infradead.org,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Yang Li <yang.lee@...ux.alibaba.com>,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next 2/2] ath9k: Remove unnecessary print function
 dev_err()

Yang Li <yang.lee@...ux.alibaba.com> writes:

> The print function dev_err() is redundant because
> platform_get_irq_byname() already prints an error.
>
> Eliminate the follow coccicheck warning:
> ./drivers/net/wireless/ath/ath9k/ahb.c:103:2-9: line 103 is redundant
> because platform_get_irq() already prints an error
>
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>

Heh, so I was the one originally insisting on keeping that err print,
but looking a bit closer now it does really appear to be redundant, so:

Acked-by: Toke Høiland-Jørgensen <toke@...e.dk>